Multi-Profiles: Add icon chooser to profiles menu

views/controls/menu/menu_item_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/menu/menu_item_view.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/stl_util-inl.h"
 #include "base/utf_string_conversions.h"
 #include "grit/ui_strings.h"
@@ skipping 466 matching lines @@
     }
   }
 
   STLDeleteElements(&removed_items_);
 }
 
 void MenuItemView::Layout() {
   if (!has_children())
     return;
 
-  // Child views are laid out right aligned and given the full height. To right
-  // align start with the last view and progress to the first.
-  for (int i = child_count() - 1, x = width() - item_right_margin_; i >= 0;
-       --i) {
-    View* child = GetChildViewAt(i);
-    int width = child->GetPreferredSize().width();
-    child->SetBounds(x - width, 0, width, height());
-    x -= width - kChildXPadding;
+  if (child_count() == 1 && GetTitle().size() == 0) {
+    // We only have one child and no title so let the view take over all the
+    // space.
+    View* child = GetChildViewAt(0);
+    gfx::Size size = child->GetPreferredSize();
+    child->SetBounds(label_start_, GetTopMargin(), size.width(), size.height());
+  } else {
+    // Child views are laid out right aligned and given the full height. To
+    // right align start with the last view and progress to the first.
+    for (int i = child_count() - 1, x = width() - item_right_margin_; i >= 0;
+         --i) {
+      View* child = GetChildViewAt(i);
+      int width = child->GetPreferredSize().width();
+      child->SetBounds(x - width, 0, width, height());
+      x -= width - kChildXPadding;
+    }
   }
 }
 
 int MenuItemView::GetAcceleratorTextWidth() {
   string16 text = GetAcceleratorText();
   return text.empty() ? 0 : GetFont().GetStringWidth(text);
 }
 
 MenuItemView::MenuItemView(MenuItemView* parent,
                            int command,
@@ skipping 220 matching lines @@
 int MenuItemView::GetBottomMargin() {
   if (bottom_margin_ >= 0)
     return bottom_margin_;
 
   MenuItemView* root = GetRootMenuItem();
   return root && root->has_icons_
       ? MenuConfig::instance().item_bottom_margin :
         MenuConfig::instance().item_no_icon_bottom_margin;
 }
 
-int MenuItemView::GetChildPreferredWidth() {
+gfx::Size MenuItemView::GetChildPreferredSize() {
   if (!has_children())
-    return 0;
+    return gfx::Size();
 
-  int width = 0;
-  for (int i = 0; i < child_count(); ++i) {
-    if (i)
-      width += kChildXPadding;
-    width += GetChildViewAt(i)->GetPreferredSize().width();
+  if (GetTitle().size() == 0 && child_count() == 1) {
+    View* child = GetChildViewAt(0);
+    return child->GetPreferredSize();
+  } else {

[sky, 2011/07/08 21:01:44]

no else (since you returned early).

[sail, 2011/07/08 21:53:57]

Done.

+    int width = 0;
+    for (int i = 0; i < child_count(); ++i) {
+      if (i)
+        width += kChildXPadding;
+      width += GetChildViewAt(i)->GetPreferredSize().width();
+    }
+    return gfx::Size(width, 0);

[sky, 2011/07/08 21:01:44]

Document why its ok to return a height of 0 here.

[sail, 2011/07/08 21:53:57]

Done.

   }
-  return width;
 }
 
 string16 MenuItemView::GetAcceleratorText() {
   if (id() == kEmptyMenuItemViewID) {
     // Don't query the delegate for menus that represent no children.
     return string16();
   }
 
   Accelerator accelerator;
   return (GetDelegate() &&
           GetDelegate()->GetAccelerator(GetCommand(), &accelerator)) ?
       accelerator.GetShortcutText() : string16();
 }
 
 }  // namespace views