Drastically reduce the transitive dependencies of jsregexp.h, making it (almost)

src/arm/regexp-macro-assembler-arm.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 10 matching lines @@
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #ifndef V8_ARM_REGEXP_MACRO_ASSEMBLER_ARM_H_
 #define V8_ARM_REGEXP_MACRO_ASSEMBLER_ARM_H_
 
+#include "arm/assembler-arm.h"
+#include "arm/assembler-arm-inl.h"

[Kevin Millikin (Chromium), 2011/07/11 10:10:52]

Drive-by comments:

I don't know if it's a good practice, but we usually assume that xxx-inl.h
includes xxx.h already.  That is, we usually include one or the other, but not
both.

Also, you should try to remember to the copyright dates :).

[Sven Panne, 2011/07/11 12:22:48]

I wasn't able to deduce this from our code, and I'm not sure if we follow this
rule consistently. Anyway, more stuff for the upcoming cleanups... :-)
Ooops, I'll remember that next time, sorry.

+
 namespace v8 {
 namespace internal {
 
 
 #ifdef V8_INTERPRETED_REGEXP
 class RegExpMacroAssemblerARM: public RegExpMacroAssembler {
  public:
   RegExpMacroAssemblerARM();
   virtual ~RegExpMacroAssemblerARM();
 };
@@ skipping 203 matching lines @@
   Label check_preempt_label_;
   Label stack_overflow_label_;
 };
 
 #endif  // V8_INTERPRETED_REGEXP
 
 
 }}  // namespace v8::internal
 
 #endif  // V8_ARM_REGEXP_MACRO_ASSEMBLER_ARM_H_