Issue 7331010: two warning fixes for the benefit of visual c when warnings are turned up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7331010: two warning fixes for the benefit of visual c when warnings are turned up (Closed)

Created:
9 years, 5 months ago by fbarchard

Modified:
9 years, 5 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/libjpeg_turbo/

Visibility:
Public.

Description

two warning fixes for the benefit of visual c when warnings are turned up BUG=none TESTED=builds with higher warning levels on windows Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91819

Patch Set 1 #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -113 lines)			Patch
	M	jdcolor.c	View		16 chunks	+42 lines, -43 lines	1 comment	Download
	M	jdhuff.c	View		20 chunks	+70 lines, -70 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fbarchard

sorry about the white space change... that is my editor that changes tabs to spaces. ...

9 years, 5 months ago (2011-07-08 08:11:03 UTC) #1

Hironori Bono

9 years, 5 months ago (2011-07-08 08:14:23 UTC) #2

LGTM. Thank you for your change. They make sense. (I will fix while space
changes when I update libjpeg-turbo to the latest trunk.)

Regards,

Hironori Bono

On 2011/07/08 08:11:03, fbarchard wrote:
> sorry about the white space change... that is my editor that changes tabs to
> spaces.  is it ok?
> There are 2 changes here that I have marked
> remove an unused variable
> change a constant 2 to 2u to avoid casting warning
> these would help, up and downstream build with higher warning levels on
windows
> 
> http://codereview.chromium.org/7331010/diff/1/jdcolor.c
> File jdcolor.c (left):
> 
> http://codereview.chromium.org/7331010/diff/1/jdcolor.c#oldcode226
> jdcolor.c:226: register JDIMENSION col;
> This is the real change
> 
> http://codereview.chromium.org/7331010/diff/1/jdhuff.c
> File jdhuff.c (right):
> 
> http://codereview.chromium.org/7331010/diff/1/jdhuff.c#newcode763
> jdhuff.c:763: #define BUFSIZE (DCTSIZE2 * 2u)
> this change avoid a casting warning

Expand Messages | Collapse Messages