Issue 7331005: Fixed version check in client_session.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7331005: Fixed version check in client_session.js (Closed)

Created:
9 years, 5 months ago by Jamie

Modified:
9 years, 5 months ago

Reviewers:
awong

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixed version check in client_session.js BUG=None TEST=Connections work again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91794

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	remoting/webapp/me2mom/client_session.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

9 years, 5 months ago (2011-07-08 01:13:02 UTC) #2

LGTM

Very sorry :(  orz

On Thu, Jul 7, 2011 at 6:10 PM, <jamiewalch@chromium.org> wrote:

> Reviewers: awong,
>
> Message:
> A simple fix for the connection problem.
>
> Description:
> Fixed version check in client_session.js
>
> BUG=None
> TEST=Connections work again.
>
>
> Please review this at
http://codereview.chromium.**org/7331005/<http://codereview.chromium.org/7331...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M remoting/webapp/me2mom/client_**session.js
>
>
> Index: remoting/webapp/me2mom/client_**session.js
> diff --git a/remoting/webapp/me2mom/**client_session.js
> b/remoting/webapp/me2mom/**client_session.js
> index 87102682d79a0264840d14420d41fb**321b4c2a6d..**
> 986f5e09f89dcf7074a65e3f103254**dcf4b781be 100644
> --- a/remoting/webapp/me2mom/**client_session.js
> +++ b/remoting/webapp/me2mom/**client_session.js
> @@ -229,7 +229,7 @@ remoting.ClientSession.**prototype.registerConnection_
> =
>     that.clientJid = xhr.responseText;
>
>     // TODO(ajwong): Remove old version support.
> -    if (that.plugin.API_VERSION_ >= 2) {
> +    if (that.plugin.apiVersion >= 2) {
>       that.plugin.connect(that.**hostJid, that.hostPublicKey,
> that.clientJid,
>                           that.accessCode);
>     } else {
>
>
>

Expand Messages | Collapse Messages