Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 7331004: Move chromedriver tests to test subdirectory. Add script to run all chromedriver (Closed)

Created:
9 years, 5 months ago by kkania
Modified:
9 years, 5 months ago
Reviewers:
dennis_jeffrey
CC:
chromium-reviews, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move chromedriver tests to test subdirectory. Add script to run all chromedriver tests. Delete unused test script. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91864

Patch Set 1 #

Total comments: 4

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1767 lines) Patch
D chrome/test/webdriver/WEBDRIVER_TESTS View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/test/webdriver/chromedriver_launcher.py View 1 chunk +0 lines, -207 lines 0 comments Download
D chrome/test/webdriver/chromedriver_paths.py View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/webdriver/chromedriver_tests.py View 1 chunk +0 lines, -727 lines 0 comments Download
D chrome/test/webdriver/gtest_text_test_runner.py View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/test/webdriver/iframe_src.html View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/webdriver/run_webdriver_tests.py View 1 chunk +0 lines, -300 lines 0 comments Download
D chrome/test/webdriver/state_zip_labels.txt View 1 chunk +0 lines, -22 lines 0 comments Download
A + chrome/test/webdriver/test/WEBDRIVER_TESTS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/webdriver/test/chromedriver_launcher.py View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/webdriver/test/chromedriver_paths.py View 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/test/webdriver/test/chromedriver_tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/webdriver/test/gtest_text_test_runner.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/webdriver/test/iframe_src.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/webdriver/test/run_chromedriver_tests.py View 1 1 chunk +17 lines, -0 lines 0 comments Download
A + chrome/test/webdriver/test/run_webdriver_tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/webdriver/test/state_zip_labels.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/webdriver/test/test_page.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/webdriver/test/upload.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/webdriver/test_page.html View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/webdriver/upload.html View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/webdriver/webdriver_remote_tests.py View 1 chunk +0 lines, -301 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
Just moving test files to subdir. No changes except adding additional os.pardir to appropriate place ...
9 years, 5 months ago (2011-07-08 00:46:46 UTC) #1
dennis_jeffrey
http://codereview.chromium.org/7331004/diff/1/chrome/test/webdriver/test/run_chromedriver_tests.py File chrome/test/webdriver/test/run_chromedriver_tests.py (right): http://codereview.chromium.org/7331004/diff/1/chrome/test/webdriver/test/run_chromedriver_tests.py#newcode6 chrome/test/webdriver/test/run_chromedriver_tests.py:6: """Runs all of the chromedriver tests. nit: 'chromedriver' --> ...
9 years, 5 months ago (2011-07-08 01:26:40 UTC) #2
kkania
http://codereview.chromium.org/7331004/diff/1/chrome/test/webdriver/test/run_chromedriver_tests.py File chrome/test/webdriver/test/run_chromedriver_tests.py (right): http://codereview.chromium.org/7331004/diff/1/chrome/test/webdriver/test/run_chromedriver_tests.py#newcode6 chrome/test/webdriver/test/run_chromedriver_tests.py:6: """Runs all of the chromedriver tests. On 2011/07/08 01:26:40, ...
9 years, 5 months ago (2011-07-08 01:30:21 UTC) #3
dennis_jeffrey
9 years, 5 months ago (2011-07-08 01:32:27 UTC) #4
LGTM

Please update the CL description to mention the file that is being removed.

Powered by Google App Engine
This is Rietveld 408576698