Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 7330003: Add vim filetype settings for DEPS. (Closed)

Created:
9 years, 5 months ago by scherkus (not reviewing)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add vim filetype settings for DEPS. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91783

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated comment #

Total comments: 2

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/vim/filetypes.vim View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
just found out about this file! neat! DISCLAIMER: I know nothing about vim settings files
9 years, 5 months ago (2011-07-07 22:30:23 UTC) #1
tony
I just added the file yesterday :) Also, I know close to nothing about vim ...
9 years, 5 months ago (2011-07-07 22:32:48 UTC) #2
tony
http://codereview.chromium.org/7330003/diff/1/tools/vim/filetypes.vim File tools/vim/filetypes.vim (right): http://codereview.chromium.org/7330003/diff/1/tools/vim/filetypes.vim#newcode1 tools/vim/filetypes.vim:1: " To get syntax highlighting and tab settings for ...
9 years, 5 months ago (2011-07-07 22:33:18 UTC) #3
scherkus (not reviewing)
done! sweet!
9 years, 5 months ago (2011-07-07 22:36:44 UTC) #4
tfarina
http://codereview.chromium.org/7330003/diff/6001/tools/vim/filetypes.vim File tools/vim/filetypes.vim (right): http://codereview.chromium.org/7330003/diff/6001/tools/vim/filetypes.vim#newcode3 tools/vim/filetypes.vim:3: " so /path/to/src/vim/filetypes.vim While you here, shouldn't this be: ...
9 years, 5 months ago (2011-07-07 23:34:06 UTC) #5
commit-bot: I haz the power
List of reviewers changed.
9 years, 5 months ago (2011-07-07 23:43:55 UTC) #6
scherkus (not reviewing)
9 years, 5 months ago (2011-07-08 00:16:20 UTC) #7
http://codereview.chromium.org/7330003/diff/6001/tools/vim/filetypes.vim
File tools/vim/filetypes.vim (right):

http://codereview.chromium.org/7330003/diff/6001/tools/vim/filetypes.vim#newc...
tools/vim/filetypes.vim:3: "     so /path/to/src/vim/filetypes.vim
On 2011/07/07 23:34:06, tfarina wrote:
> While you here, shouldn't this be:
> 
> /path/to/chrome/src/tools/vim/filetypes.vim ?
> 	

Done.

Powered by Google App Engine
This is Rietveld 408576698