Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7329032: Mac. Auto show and hide Bookmark Bar "Other Bookmarks" folder button depending on whether it's em... (Closed)

Created:
9 years, 5 months ago by mafv
Modified:
9 years, 5 months ago
Reviewers:
tfarina, mrossetti, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Mac. Auto show and hide Bookmark Bar "Other Bookmarks" folder button depending on whether it's empty. BUG=64997 TEST=None R=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91907

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 5

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 6 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mafv
9 years, 5 months ago (2011-07-08 22:30:39 UTC) #1
tfarina
http://codereview.chromium.org/7329032/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right): http://codereview.chromium.org/7329032/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm#newcode1326 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:1326: BOOL visible = [otherBookmarksButton_ bookmarkNode]->child_count() > 0; can you ...
9 years, 5 months ago (2011-07-08 22:34:39 UTC) #2
mafv
9 years, 5 months ago (2011-07-08 22:38:43 UTC) #3
mrossetti
LGTM with one small change to use empty(). http://codereview.chromium.org/7329032/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right): http://codereview.chromium.org/7329032/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm#newcode1322 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:1322: - ...
9 years, 5 months ago (2011-07-08 22:46:04 UTC) #4
mafv
http://codereview.chromium.org/7329032/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right): http://codereview.chromium.org/7329032/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm#newcode1326 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:1326: BOOL visible = [otherBookmarksButton_ bookmarkNode]->child_count() > 0; On 2011/07/08 ...
9 years, 5 months ago (2011-07-08 22:47:21 UTC) #5
mafv
http://codereview.chromium.org/7329032/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right): http://codereview.chromium.org/7329032/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm#newcode1322 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:1322: - (BOOL)setOtherBookmarksButtonCorrectVisibility { On 2011/07/08 22:46:04, mrossetti wrote: > ...
9 years, 5 months ago (2011-07-08 22:49:21 UTC) #6
mafv
9 years, 5 months ago (2011-07-08 22:57:20 UTC) #7 
Thanks for the speedy reviews, guys.

Powered by Google App Engine
This is Rietveld 408576698