Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 7329024: Revert 91859 - Porting ppapi_tests framework to postMessage. (Closed)

Created:
9 years, 5 months ago by dmichael (off chromium)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 91859 - Porting ppapi_tests framework to postMessage. Some tests still rely on scripting, so we changed to using InstancePrivate (since scripting will disappear from Instance soon). Also use conditional compilation so that if compiled as untrusted with NaCl, the tests use Instance instead of InstancePrivate. This means that tests which rely on scripting aren't runnable in NaCl. I also added a gyp option: pepper_scripting. The default is that scripting is on in this CL, but it will make it easy to turn it off in local builds. Soon we'll switch the default to no scripting, and soon after we can remove the option entirely. BUG=82606 TEST=these tests Review URL: http://codereview.chromium.org/7312008 TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -178 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M ppapi/tests/test_case.h View 5 chunks +2 lines, -13 lines 0 comments Download
M ppapi/tests/test_case.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M ppapi/tests/test_case.html View 2 chunks +1 line, -65 lines 0 comments Download
M ppapi/tests/test_post_message.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M ppapi/tests/test_url_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_var_deprecated.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_var_deprecated.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M ppapi/tests/testing_instance.h View 4 chunks +1 line, -24 lines 0 comments Download
M ppapi/tests/testing_instance.cc View 7 chunks +17 lines, -20 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dmichael (off chromium)
9 years, 5 months ago (2011-07-08 17:06:29 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698