Issue 7329011: Chromoting: Move set(Client|Host)Mode into remoting namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7329011: Chromoting: Move set(Client|Host)Mode into remoting namespace. (Closed)

Created:
9 years, 5 months ago by garykac

Modified:
9 years, 5 months ago

Reviewers:
awong, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Chromoting: Move set(Client|Host)Mode into remoting namespace. Likewise for cancelPendingOperation. This fixes failing JS calls from choice.html (e.g., "OK" button for "Invalid Access Code") Also replace occurrences of: function f() {} remoting.f = f; with: remoting.f = function() {} to be consistent. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91871

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove blank line #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -21 lines)			Patch
	M	remoting/webapp/me2mom/remoting.js	View	1	10 chunks	+18 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jamie

LGTM with one nit. http://codereview.chromium.org/7329011/diff/1/remoting/webapp/me2mom/remoting.js File remoting/webapp/me2mom/remoting.js (right): http://codereview.chromium.org/7329011/diff/1/remoting/webapp/me2mom/remoting.js#newcode269 remoting/webapp/me2mom/remoting.js:269: Is this blank line deliberate? ...

9 years, 5 months ago (2011-07-08 16:09:45 UTC) #2

garykac

9 years, 5 months ago (2011-07-08 17:36:41 UTC) #3

http://codereview.chromium.org/7329011/diff/1/remoting/webapp/me2mom/remoting.js
File remoting/webapp/me2mom/remoting.js (right):

http://codereview.chromium.org/7329011/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting.js:269: 
On 2011/07/08 16:09:45, Jamie wrote:
> Is this blank line deliberate? I can't see why it's been added.

Curious. It was not intended. Removed.

Expand Messages | Collapse Messages