Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 7329008: Added the reference build to the frame rate test. (Closed)

Created:
9 years, 5 months ago by jrt
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Added the reference build to the frame rate test. Now that the reference build includes webkitRequestAnimationFrame (r91338), we can use it for the frame rate performance test. TEST=performance_ui_tests --gtest_filter=FrameRateTest_Reference.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91868

Patch Set 1 #

Total comments: 2

Patch Set 2 : Redesigned the FRAME_RATE_TEST macro. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 1 1 chunk +10 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jrt
9 years, 5 months ago (2011-07-07 23:20:29 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/7329008/diff/1/chrome/test/perf/frame_rate/frame_rate_tests.cc File chrome/test/perf/frame_rate/frame_rate_tests.cc (right): http://codereview.chromium.org/7329008/diff/1/chrome/test/perf/frame_rate/frame_rate_tests.cc#newcode96 chrome/test/perf/frame_rate/frame_rate_tests.cc:96: FRAME_RATE_TEST(Blank_Steady, "steady"); eventually, i imagine we'll have more ...
9 years, 5 months ago (2011-07-07 23:51:02 UTC) #2
jrt
New snapshot uploaded. http://codereview.chromium.org/7329008/diff/1/chrome/test/perf/frame_rate/frame_rate_tests.cc File chrome/test/perf/frame_rate/frame_rate_tests.cc (right): http://codereview.chromium.org/7329008/diff/1/chrome/test/perf/frame_rate/frame_rate_tests.cc#newcode96 chrome/test/perf/frame_rate/frame_rate_tests.cc:96: FRAME_RATE_TEST(Blank_Steady, "steady"); On 2011/07/07 23:51:02, darin ...
9 years, 5 months ago (2011-07-08 00:02:11 UTC) #3
darin (slow to review)
LGTM
9 years, 5 months ago (2011-07-08 16:18:39 UTC) #4
commit-bot: I haz the power
9 years, 5 months ago (2011-07-08 17:20:19 UTC) #5
Change committed as 91868

Powered by Google App Engine
This is Rietveld 408576698