Don't perform the default browser check when running the page cycler. This

Don't perform the default browser check when running the page cycler.  This
might be causing some infobar-related noise in the page cycler results.

BUG=88687
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91792

[cmp, 2011-07-07 23:22:28]

lgtm

This will affect the ref build results, too.  It's a shot in the dark, I would
like to watch the run to see what happens before it lands but may not get to it
in time.  I'm surprised that the infobar animation (if it's happening) may cause
such a problem on the morejs page cycler.

[commit-bot: I haz the power, 2011-07-08 01:09:07]

Change committed as 91792

[Paweł Hajdan Jr., 2011-07-19 20:32:16]

http://codereview.chromium.org/7329007/diff/1/chrome/test/page_cycler/page_cy...
File chrome/test/page_cycler/page_cycler_test.cc (right):

http://codereview.chromium.org/7329007/diff/1/chrome/test/page_cycler/page_cy...
chrome/test/page_cycler/page_cycler_test.cc:140:
launch_arguments_.AppendSwitch(switches::kNoDefaultBrowserCheck);
Is this needed? I think test_launcher_utils already appends
kNoDefaultBrowserCheck .

http://codereview.chromium.org/7329007/diff/1/chrome/test/page_cycler/page_cy...
chrome/test/page_cycler/page_cycler_test.cc:144: UITest::SetUp();
I think that might be a problem - it seems like it should call UIPerfTest::SetUp
(which means removing the method override).

[abarth-chromium, 2011-07-19 21:34:37]

http://codereview.chromium.org/7329007/diff/1/chrome/test/page_cycler/page_cy...
File chrome/test/page_cycler/page_cycler_test.cc (right):

http://codereview.chromium.org/7329007/diff/1/chrome/test/page_cycler/page_cy...
chrome/test/page_cycler/page_cycler_test.cc:140:
launch_arguments_.AppendSwitch(switches::kNoDefaultBrowserCheck);
> Is this needed?

This CL can be reverted.  It didn't help.

http://codereview.chromium.org/7329007/diff/1/chrome/test/page_cycler/page_cy...
chrome/test/page_cycler/page_cycler_test.cc:144: UITest::SetUp();
Dunno, could be.  That seems unrelated to this patch, however.

[Paweł Hajdan Jr., 2011-07-21 18:28:27]

http://codereview.chromium.org/7329007/diff/1/chrome/test/page_cycler/page_cy...
File chrome/test/page_cycler/page_cycler_test.cc (right):

http://codereview.chromium.org/7329007/diff/1/chrome/test/page_cycler/page_cy...
chrome/test/page_cycler/page_cycler_test.cc:140:
launch_arguments_.AppendSwitch(switches::kNoDefaultBrowserCheck);
On 2011/07/19 21:34:37, abarth wrote:
> > Is this needed?
> 
> This CL can be reverted.  It didn't help.

Okay, I'm doing that: http://codereview.chromium.org/7464038/

Thank you for reply.