Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7329003: Revert 91761 - GTK: More 2.18 goodness. Move from macros to real accessor functions. (Closed)

Created:
9 years, 5 months ago by Elliot Glaysher
Modified:
9 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, nkostylev+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Randy Smith (Not in Mondays), Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 91761 - GTK: More 2.18 goodness. Move from macros to real accessor functions. This does not take care of everything! There are many deprecated macros that we can't replace because their accessor replacements were in 2.20 or later. BUG=none TEST=none Review URL: http://codereview.chromium.org/7227027 TBR=erg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -95 lines) Patch
M chrome/browser/chromeos/login/screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/native_dialog_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_common_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/gtk_key_bindings_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_list_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/crypto_module_password_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/custom_button.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/gtk/gtk_chrome_button.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/gtk/gtk_chrome_link_button.cc View 6 chunks +8 lines, -8 lines 0 comments Download
MM chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.cc View 2 chunks +4 lines, -4 lines 0 comments Download
MM chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/gtk/gtk_custom_menu_item.cc View 3 chunks +5 lines, -3 lines 0 comments Download
MM chrome/browser/ui/gtk/gtk_expanded_container.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/gtk/gtk_floating_container.cc View 3 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/ui/gtk/gtk_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/ui/gtk/location_bar_view_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/gtk/location_bar_view_gtk.cc View 5 chunks +4 lines, -15 lines 0 comments Download
MM chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/gtk/reload_button_gtk.cc View 3 chunks +4 lines, -3 lines 0 comments Download
MM chrome/browser/ui/gtk/rounded_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/gtk/tabs/tab_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/login/login_prompt_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
MM ui/gfx/gtk_preserve_window.cc View 1 chunk +1 line, -1 line 0 comments Download
MM webkit/tools/test_shell/webwidget_host_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Elliot Glaysher
9 years, 5 months ago (2011-07-07 22:30:04 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698