Remove obsolete comment about app_unittests in chromium_builder_dbg_tsan_win target.

Remove obsolete comment about app_unittests in chromium_builder_dbg_tsan_win target.

BUG=72317
TEST=None

R=tony@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91877

[tony, 2011-07-08 01:30:03]

http://codereview.chromium.org/7329002/diff/2001/build/all.gyp
File build/all.gyp (left):

http://codereview.chromium.org/7329002/diff/2001/build/all.gyp#oldcode484
build/all.gyp:484: '../chrome/app/locales/locales.gyp:*',
Is it possible to remove locales or does one of the tests depend on it?  I think
that's what the comment you're removing is referring to.

[tfarina, 2011-07-08 01:39:53]

http://codereview.chromium.org/7329002/diff/2001/build/all.gyp
File build/all.gyp (left):

http://codereview.chromium.org/7329002/diff/2001/build/all.gyp#oldcode484
build/all.gyp:484: '../chrome/app/locales/locales.gyp:*',
On 2011/07/08 01:30:03, tony wrote:
> Is it possible to remove locales or does one of the tests depend on it?  I
think
> that's what the comment you're removing is referring to.

Removed. I'm running through the trybots. I'll see tomorrow what they say.

[tfarina, 2011-07-08 15:13:31]

Trybots are fine. PTAL!

[tony, 2011-07-08 17:05:43]

http://codereview.chromium.org/7329002/diff/1002/build/all.gyp
File build/all.gyp (left):

http://codereview.chromium.org/7329002/diff/1002/build/all.gyp#oldcode479
build/all.gyp:479: '../app/app.gyp:app_unittests',
I don't think we can remove this yet.  This target is used on the Windows Tests
tsan bot:
http://build.chromium.org/p/chromium.memory/waterfall?builder=Windows%20Tests...

Specifically, in the memory test: app step, it runs app_unittests.  We need to
fix the bot to run sql_unittests instead, then we can remove this target.

If you want, we can just remove the comment and locales.gyp in this patch.

[tfarina, 2011-07-08 17:17:10]

On 2011/07/08 17:05:43, tony wrote:
> http://codereview.chromium.org/7329002/diff/1002/build/all.gyp
> File build/all.gyp (left):
> 
> http://codereview.chromium.org/7329002/diff/1002/build/all.gyp#oldcode479
> build/all.gyp:479: '../app/app.gyp:app_unittests',
> I don't think we can remove this yet.  This target is used on the Windows
Tests
> tsan bot:
>
http://build.chromium.org/p/chromium.memory/waterfall?builder=Windows%2520Tes...
> 
> Specifically, in the memory test: app step, it runs app_unittests.  We need to
> fix the bot to run sql_unittests instead, then we can remove this target.
> 
It seems Robert landed a patch that fix this.
http://codereview.chromium.org/7248051/diff/1/masters/master.chromium.memory/...

We just need to restart the master. He said he was going to ask Marc to do this
on this weekend.

> If you want, we can just remove the comment and locales.gyp in this patch.

Done.

[tony, 2011-07-08 17:18:58]

Ah, I see.  OK, let's wait until after the bot restart before removing
app_unittests (otherwise that bot step will fail).

LGTM!