chrome/browser/extensions/extension_service.cc - Issue 7328029: Use process-per-app-instance for hosted apps without background permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 7328029: Use process-per-app-instance for hosted apps without background permission. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix incognito function. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/geolocation/chrome_geolocation_permission_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 5748626e86709090627222e04a809149ec7287ad..8449ce375ade263bca33f26faf672eaee4c379f0 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -2171,12 +2171,16 @@ const Extension* ExtensionService::GetExtensionByWebExtent(const GURL& url) {

}

bool ExtensionService::ExtensionBindingsAllowed(const GURL& url) {

- // Allow bindings for all packaged extension.

- if (GetExtensionByURL(url))

+ // Allow bindings for all packaged extensions.

+ // Note that GetExtensionByURL may return an Extension for hosted apps

+ // if the URL came from GetEffectiveURL.

+ const Extension* extension = GetExtensionByURL(url);

+ if (extension && extension->GetType() != Extension::TYPE_HOSTED_APP)

return true;

// Allow bindings for all component, hosted apps.

- const Extension* extension = GetExtensionByWebExtent(url);

+ if (!extension)

+ extension = GetExtensionByWebExtent(url);

return (extension && extension->location() == Extension::COMPONENT);

}