Use process-per-app-instance for hosted apps without background permission.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include "base/command_line.h"
 #include "chrome/app/breakpad_mac.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/character_encoding.h"
@@ skipping 80 matching lines @@
       profile->GetExtensionProcessManager();
   CHECK(process_manager);
 
   // This can happen if somebody typos a chrome-extension:// URL.
   const Extension* extension = service->GetExtensionByURL(site);
   if (!extension)
     return;
 
   site_instance->GetProcess()->mark_is_extension_process();
 
-  // Register the association between extension and process with
-  // ExtensionProcessManager.
-  process_manager->RegisterExtensionProcess(extension->id(), process->id());
-
   if (extension->is_app()) {
     render_view_host->Send(
         new ExtensionMsg_ActivateApplication(extension->id()));
     // Record which, if any, installed app is associated with this process.
     // TODO(aa): Totally lame to store this state in a global map in extension
     // service. Can we get it from EPM instead?
     service->SetInstalledAppForRenderer(process->id(), extension);
   }
 
   // Some extensions use chrome:// URLs.
@@ skipping 72 matching lines @@
   const Extension* extension =
       profile->GetExtensionService()->GetExtensionByWebExtent(url);
   if (!extension)
     return url;
 
   // If the URL is part of an extension's web extent, convert it to an
   // extension URL.
   return extension->GetResourceURL(url.path());
 }
 
+bool ChromeContentBrowserClient::ShouldUseProcessPerSite(Profile* profile,
+                                                         const GURL& url) {

[Matt Perry, 2011/07/08 22:18:35]

rename url to effective_url to clarify expectations

[Charlie Reis, 2011/07/08 22:49:50]

Done.

+  // Non-extension URLs should generally use process-per-site-instance.
+  // We expect url to be the effective URL, so hosted apps URLs should have
+  // an extension scheme by now.
+  if (!url.SchemeIs(chrome::kExtensionScheme))
+    return false;
+
+  if (!profile || !profile->GetExtensionService())
+    return false;
+
+  const Extension* extension =
+      profile->GetExtensionService()->GetExtensionByURL(url);
+  if (!extension)
+    return false;
+
+  // If the URL is part of a hosted app that does not have the background
+  // permission, we want to give each instance its own process to improve
+  // responsiveness.
+  if (extension->GetType() == Extension::TYPE_HOSTED_APP &&
+      !extension->HasAPIPermission(ExtensionAPIPermission::kBackground))
+    return false;
+
+  // Hosted apps that have the background permission must use process per site,
+  // since all instances can make synchronous calls to the background window.
+  // Other extensions should use process per site as well.
+  return true;
+}
+
 bool ChromeContentBrowserClient::IsURLSameAsAnySiteInstance(const GURL& url) {
   return url == GURL(chrome::kChromeUICrashURL) ||
          url == GURL(chrome::kChromeUIKillURL) ||
          url == GURL(chrome::kChromeUIHangURL) ||
          url == GURL(chrome::kChromeUIShorthangURL);
 }
 
 std::string ChromeContentBrowserClient::GetCanonicalEncodingNameByAliasName(
     const std::string& alias_name) {
   return CharacterEncoding::GetCanonicalEncodingNameByAliasName(alias_name);
@@ skipping 423 matching lines @@
 #if defined(USE_NSS)
 crypto::CryptoModuleBlockingPasswordDelegate*
     ChromeContentBrowserClient::GetCryptoPasswordDelegate(
         const GURL& url) {
   return browser::NewCryptoModuleBlockingDialogDelegate(
       browser::kCryptoModulePasswordKeygen, url.host());
 }
 #endif
 
 }  // namespace chrome