Multi-Profiles: Pass profile directories by reference

Multi-Profiles: Pass profile directories by reference

willchan pointed out that NewRunnableFunction will copy parameters even if the method signature contains references. See:
http://codereview.chromium.org/7321011/diff/2001/chrome/browser/profiles/profile_manager.cc#newcode46

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91867

[willchan no longer on Chromium, 2011-07-08 16:07:12]

LGTM

On Fri, Jul 8, 2011 at 7:04 PM,  <sail@chromium.org> wrote:
> Reviewers: willchan,
>
> Description:
> Multi-Profiles: Pass profile directories by reference
>
> willchan pointed out that NewRunnableFunction will copy parameters even if
> the
> method signature contains references. See:
>
http://codereview.chromium.org/7321011/diff/2001/chrome/browser/profiles/prof...
>
> BUG=
> TEST=
>
>
> Please review this at http://codereview.chromium.org/7328021/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/profiles/profile_manager.cc
>
>
> Index: chrome/browser/profiles/profile_manager.cc
> diff --git a/chrome/browser/profiles/profile_manager.cc
> b/chrome/browser/profiles/profile_manager.cc
> index
>
cc3647cb380fb3657554d71cfadb0f76335210fe..f0f5f44b6ae23158cde92afc31c474bd641baf76
> 100644
> --- a/chrome/browser/profiles/profile_manager.cc
> +++ b/chrome/browser/profiles/profile_manager.cc
> @@ -43,9 +43,9 @@
>
>  namespace {
>
> -void DeleteProfileDirectories(std::vector<FilePath> paths) {
> +void DeleteProfileDirectories(const std::vector<FilePath>& paths) {
>   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
> -  for (std::vector<FilePath>::iterator it = paths.begin();
> +  for (std::vector<FilePath>::const_iterator it = paths.begin();
>        it != paths.end(); ++it) {
>     file_util::Delete(*it, true);
>   }
>
>
>

[commit-bot: I haz the power, 2011-07-08 17:09:52]

Change committed as 91867