Issue 7328017: Reland r91815, "Clean up RegisterProtocolFactory calls."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7328017: Reland r91815, "Clean up RegisterProtocolFactory calls." (Closed)

Created:
9 years, 5 months ago by willchan no longer on Chromium

Modified:
9 years, 5 months ago

Reviewers:
michaeln

CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Reland r91815, "Clean up RegisterProtocolFactory calls." It had broken the mac canaries with the warning: cc1plus: warnings being treated as errors /b/build/slave/Webkit_Mac10_5__dbg__2_/build/src/webkit/appcache/appcache_update_job_unittest.cc:556: warning: 'appcache::AppCacheUpdateJobTest' has a field 'appcache::AppCacheUpdateJobTest::io_thread_' whose type uses the anonymous namespace This is the old gcc bug. I think the problem is Mac 10.5 vs 10.6. I'm working around by removing the anonymous namespace. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91836

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -98 lines)			Patch
	M	net/url_request/url_request_job_factory.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	webkit/appcache/appcache_update_job_unittest.cc	View		25 chunks	+88 lines, -95 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

TBR: michaeln

Expand Messages | Collapse Messages