Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 7328016: Align host and target architectures when building v8_shell. (Closed)

Created:
9 years, 5 months ago by mnaganov (inactive)
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Align host and target architectures when building v8_shell. This is a fix after r8356. Otherwise, shell can't be built on a 64-bit host. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8581

Patch Set 1 #

Patch Set 2 : Also add for v8_snapshot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/gyp/v8.gyp View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mnaganov (inactive)
9 years, 5 months ago (2011-07-08 10:10:29 UTC) #1
Satish
On 2011/07/08 10:10:29, Mikhail Naganov (Chromium) wrote: Unfortunately this change does not work in our ...
9 years, 5 months ago (2011-07-08 11:04:49 UTC) #2
mnaganov (inactive)
On 2011/07/08 11:04:49, Satish wrote: > On 2011/07/08 10:10:29, Mikhail Naganov (Chromium) wrote: > > ...
9 years, 5 months ago (2011-07-08 11:52:34 UTC) #3
Søren Thygesen Gjesse
9 years, 5 months ago (2011-07-08 13:18:55 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698