Issue 7328015: Revert r91815, "Clean up RegisterProtocolFactory calls." (broke mac canaries)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7328015: Revert r91815, "Clean up RegisterProtocolFactory calls." (broke mac canaries) (Closed)

Created:
9 years, 5 months ago by caseq

Modified:
9 years, 5 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Revert r91815, "Clean up RegisterProtocolFactory calls." (broke mac canaries) BUG=none TEST=successful build on mac TBR=willchan Sample build log: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%282%29/builds/3140/steps/compile/logs/stdio cc1plus: warnings being treated as errors /b/build/slave/Webkit_Mac10_5__dbg__2_/build/src/webkit/appcache/appcache_update_job_unittest.cc:556: warning: 'appcache::AppCacheUpdateJobTest' has a field 'appcache::AppCacheUpdateJobTest::io_thread_' whose type uses the anonymous namespace

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -92 lines)			Patch
	M	net/url_request/url_request_job_factory.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	webkit/appcache/appcache_update_job_unittest.cc	View		25 chunks	+92 lines, -89 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

caseq

Hi Will, tried to reach you before reverting, but you seemed to be offline.

9 years, 5 months ago (2011-07-08 10:07:46 UTC) #1

willchan no longer on Chromium

9 years, 5 months ago (2011-07-08 10:18:05 UTC) #2

Thanks for the revert. I'm surprised the commit-bot didn't catch this
but the canary bot did.

Oh I see why. JFDSKLFJD the Mac canary is using an older version of
gcc! FUUUUUUUUU.

On Fri, Jul 8, 2011 at 1:07 PM,  <caseq@chromium.org> wrote:
> Reviewers: willchan,
>
> Message:
> Hi Will,
>
> tried to reach you before reverting, but you seemed to be offline.
>
>
> Description:
> Revert r91815, "Clean up RegisterProtocolFactory calls." (broke mac
> canaries)
>
> BUG=none
> TEST=successful build on mac
> TBR=willchan
>
> Sample build log:
>
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28db...
>
> cc1plus: warnings being treated as errors
>
/b/build/slave/Webkit_Mac10_5__dbg__2_/build/src/webkit/appcache/appcache_update_job_unittest.cc:556:
> warning: 'appcache::AppCacheUpdateJobTest' has a field
> 'appcache::AppCacheUpdateJobTest::io_thread_' whose type uses the anonymous
> namespace
>
>
> Please review this at http://codereview.chromium.org/7328015/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M net/url_request/url_request_job_factory.h
>  M webkit/appcache/appcache_update_job_unittest.cc
>
>
>

Expand Messages | Collapse Messages