Issue 7328006: DEPS: bump nacl revision. Reenable nacl integration tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7328006: DEPS: bump nacl revision. Reenable nacl integration tests. (Closed)

Created:
9 years, 5 months ago by polina

Modified:
9 years, 5 months ago

Reviewers:
noelallen_use_chromium

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DEPS: bump nacl revision. NaCl integration tests are still disabled due to a recent change to ppapi/ppapi_cpp.gypi that breaks native_client/site_scons/gyp_extract.py parser. The breakage was not detected because the tests were off. The parser must be fixed first in native_client. BUG=none TEST=bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91789

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	DEPS	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

noelallen_use_chromium

LGTM+ http://codereview.chromium.org/7328006/diff/1003/chrome/test/nacl_test_injection/buildbot_nacl_integration.py File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right): http://codereview.chromium.org/7328006/diff/1003/chrome/test/nacl_test_injection/buildbot_nacl_integration.py#newcode26 chrome/test/nacl_test_injection/buildbot_nacl_integration.py:26: #return Keep tests off, we can fix that ...

9 years, 5 months ago (2011-07-08 00:50:42 UTC) #1

polina

9 years, 5 months ago (2011-07-08 01:02:43 UTC) #2

On 2011/07/08 00:50:42, noelallen wrote:
> LGTM+
> 
>
http://codereview.chromium.org/7328006/diff/1003/chrome/test/nacl_test_inject...
> File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right):
> 
>
http://codereview.chromium.org/7328006/diff/1003/chrome/test/nacl_test_inject...
> chrome/test/nacl_test_injection/buildbot_nacl_integration.py:26: #return
> Keep tests off, we can fix that as a separate change.

Committed revision 91789.

Expand Messages | Collapse Messages