Makes views menu open submenus immediately when pressing a key. We

Makes views menu open submenus immediately when pressing a key. We
need to do this immediately, otherwise if the user types fast enough
the accelerator goes to the wrong menu.

BUG=84442
TEST=see bug
R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91806

[Ben Goodger (Google), 2011-07-07 22:01:04]

LGTM

On Thu, Jul 7, 2011 at 3:00 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Makes views menu open submenus immediately when pressing a key. We
> need to do this immediately, otherwise if the user types fast enough
> the accelerator goes to the wrong menu.
>
> BUG=84442
> TEST=see bug
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/7328004/<http://codereview.chromium.org/7328...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M views/controls/menu/menu_**controller.cc
>
>
> Index: views/controls/menu/menu_**controller.cc
> diff --git a/views/controls/menu/menu_**controller.cc
> b/views/controls/menu/menu_**controller.cc
> index 84544f1b0f258ffc1b9cadbc661ed7**d504207ab2..**
> 31726f1c59b2f342348521d21142b6**bf9af6eb07 100644
> --- a/views/controls/menu/menu_**controller.cc
> +++ b/views/controls/menu/menu_**controller.cc
> @@ -1682,7 +1682,7 @@ bool MenuController::**AcceptOrSelect(MenuItemView*
> parent,
>     // There's only one match, activate it (or open if it has a submenu).
>     if (submenu->GetMenuItemAt(**details.first_match)->**HasSubmenu()) {
>       SetSelection(submenu->**GetMenuItemAt(details.first_**match),
> -                   SELECTION_OPEN_SUBMENU);
> +                   SELECTION_OPEN_SUBMENU | SELECTION_UPDATE_IMMEDIATELY);
>     } else {
>       Accept(submenu->GetMenuItemAt(**details.first_match), 0);
>       return true;
>
>
>