Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 7327034: Commits http://codereview.chromium.org/7157001/. (Closed)

Created:
9 years, 5 months ago by henrika_dont_use
Modified:
9 years, 5 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Commits http://codereview.chromium.org/7157001/. BUG=none TEST=none Merged back into 7157001. Ignore this CL.

Patch Set 1 #

Patch Set 2 : Removed chrome dependencices in content/renderer #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+799 lines, -714 lines) Patch
M chrome/browser/media/media_internals.h View 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/media/media_internals.cc View 2 chunks +12 lines, -14 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.h View 6 chunks +12 lines, -20 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 11 chunks +25 lines, -39 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 7 chunks +17 lines, -27 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 14 chunks +45 lines, -58 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 9 chunks +41 lines, -62 lines 0 comments Download
M content/browser/renderer_host/media/media_observer.h View 1 chunk +6 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/mock_media_observer.h View 1 chunk +8 lines, -11 lines 0 comments Download
M content/common/media/audio_messages.h View 1 chunk +79 lines, -82 lines 0 comments Download
M content/renderer/media/audio_device.h View 7 chunks +67 lines, -20 lines 0 comments Download
M content/renderer/media/audio_device.cc View 12 chunks +23 lines, -64 lines 0 comments Download
M content/renderer/media/audio_input_device.h View 6 chunks +61 lines, -19 lines 0 comments Download
M content/renderer/media/audio_input_device.cc View 8 chunks +20 lines, -62 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.h View 4 chunks +3 lines, -11 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.cc View 2 chunks +12 lines, -18 lines 0 comments Download
M content/renderer/media/audio_message_filter.h View 5 chunks +3 lines, -13 lines 0 comments Download
M content/renderer/media/audio_message_filter.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M content/renderer/media/audio_message_filter_unittest.cc View 8 chunks +10 lines, -21 lines 0 comments Download
M content/renderer/media/audio_renderer_impl.h View 4 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/media/audio_renderer_impl.cc View 19 chunks +58 lines, -49 lines 0 comments Download
M content/renderer/media/audio_renderer_impl_unittest.cc View 1 4 chunks +221 lines, -54 lines 4 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 9 chunks +20 lines, -16 lines 0 comments Download
M content/renderer/render_thread.h View 3 chunks +12 lines, -0 lines 0 comments Download
M content/renderer/render_thread.cc View 4 chunks +15 lines, -1 line 0 comments Download
M content/renderer/render_view.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_view.cc View 4 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tommi (sloooow) - chröme
LGTM++ great - not far to go now :) (only one bot left) if you ...
9 years, 5 months ago (2011-07-11 19:46:41 UTC) #1
jam
why create a new issue instead of just committing the change that uploaded 7157001? the ...
9 years, 5 months ago (2011-07-11 19:55:14 UTC) #2
henrika_dont_use
9 years, 5 months ago (2011-07-12 07:12:36 UTC) #3
Fixed nits. Will merge this CL with original to maintain comments.

http://codereview.chromium.org/7327034/diff/3006/content/renderer/media/audio...
File content/renderer/media/audio_renderer_impl_unittest.cc (right):

http://codereview.chromium.org/7327034/diff/3006/content/renderer/media/audio...
content/renderer/media/audio_renderer_impl_unittest.cc:36: const gfx::Rect&
rect) { return NULL; }
On 2011/07/11 19:46:41, tommi wrote:
> nit: fix indentation

Done.

http://codereview.chromium.org/7327034/diff/3006/content/renderer/media/audio...
content/renderer/media/audio_renderer_impl_unittest.cc:41:
DISALLOW_COPY_AND_ASSIGN(MockRenderProcess);
On 2011/07/11 19:46:41, tommi wrote:
> this needs to be in a private section:
> 
>  private:
>   DISALLOW_COPY_AND_ASSIGN(Foo);

Done.

Powered by Google App Engine
This is Rietveld 408576698