chrome/browser/chromeos/notifications/balloon_collection_impl.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/notifications/balloon_collection_impl.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/accessibility/accessibility_win_browsertest.cc ('K') | « chrome/browser/chromeos/notifications/balloon_collection_impl.h ('k') | chrome/browser/chromeos/notifications/balloon_view.h » ('j') | content/common/notification_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/notifications/balloon_collection_impl.cc

===================================================================

--- chrome/browser/chromeos/notifications/balloon_collection_impl.cc (revision 91880)

+++ chrome/browser/chromeos/notifications/balloon_collection_impl.cc (working copy)

@@ -29,7 +29,7 @@

BalloonCollectionImpl::BalloonCollectionImpl()

: notification_ui_(new NotificationPanel()) {

- registrar_.Add(this, NotificationType::BROWSER_CLOSED,

+ registrar_.Add(this, chrome::NOTIFICATION_BROWSER_CLOSED,

NotificationService::AllSources());

}

@@ -146,10 +146,10 @@

return base_.balloons();

}

-void BalloonCollectionImpl::Observe(NotificationType type,

+void BalloonCollectionImpl::Observe(int type,

const NotificationSource& source,

const NotificationDetails& details) {

- DCHECK(type == NotificationType::BROWSER_CLOSED);

+ DCHECK(type == chrome::NOTIFICATION_BROWSER_CLOSED);

bool app_closing = *Details<bool>(details).ptr();

// When exiting, we need to shutdown all renderers in

// BalloonViewImpl before IO thread gets deleted in the