chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/chrome_geolocation_permission_context.cc ('k') | chrome/browser/geolocation/geolocation_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

===================================================================

--- chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc (revision 91968)

+++ chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc (working copy)

@@ -20,6 +20,7 @@

#include "content/browser/geolocation/mock_location_provider.h"

#include "content/browser/renderer_host/mock_render_process_host.h"

#include "content/browser/tab_contents/test_tab_contents.h"

+#include "chrome/common/chrome_notification_types.h"

#include "content/common/geolocation_messages.h"

#include "content/common/notification_registrar.h"

#include "content/common/notification_service.h"

@@ -36,7 +37,7 @@

virtual ~ClosedDelegateTracker();

// NotificationObserver:

- virtual void Observe(NotificationType type,

+ virtual void Observe(int type,

const NotificationSource& source,

const NotificationDetails& details);

@@ -53,17 +54,17 @@

};

ClosedDelegateTracker::ClosedDelegateTracker() {

- registrar_.Add(this, NotificationType::TAB_CONTENTS_INFOBAR_REMOVED,

+ registrar_.Add(this, chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_REMOVED,

NotificationService::AllSources());

}

ClosedDelegateTracker::~ClosedDelegateTracker() {

}

-void ClosedDelegateTracker::Observe(NotificationType type,

+void ClosedDelegateTracker::Observe(int type,

const NotificationSource& source,

const NotificationDetails& details) {

- DCHECK(type.value == NotificationType::TAB_CONTENTS_INFOBAR_REMOVED);

+ DCHECK(type == chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_REMOVED);

removed_infobar_delegates_.insert(

Details<InfoBarRemovedDetails>(details)->first);

}