chrome/browser/extensions/extension_debugger_api.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_debugger_api.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_cookies_api.cc ('k') | chrome/browser/extensions/extension_disabled_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_debugger_api.cc

===================================================================

--- chrome/browser/extensions/extension_debugger_api.cc (revision 91968)

+++ chrome/browser/extensions/extension_debugger_api.cc (working copy)

@@ -24,6 +24,7 @@

#include "content/browser/debugger/devtools_client_host.h"

#include "content/browser/debugger/devtools_manager.h"

#include "content/browser/tab_contents/tab_contents.h"

+#include "chrome/common/chrome_notification_types.h"

#include "content/common/devtools_messages.h"

#include "content/common/notification_service.h"

@@ -53,7 +54,7 @@

private:

// NotificationObserver implementation.

- virtual void Observe(NotificationType type,

+ virtual void Observe(int type,

const NotificationSource& source,

const NotificationDetails& details);

void OnDispatchOnInspectorFrontend(const std::string& data);

@@ -116,7 +117,7 @@

AttachedClientHosts::GetInstance()->Add(this);

// Detach from debugger when extension unloads.

- registrar_.Add(this, NotificationType::EXTENSION_UNLOADED,

+ registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,

Source<Profile>(tab_contents_->profile()));

// Attach to debugger and tell it we are ready.

@@ -194,10 +195,10 @@

}

void ExtensionDevToolsClientHost::Observe(

- NotificationType type,

+ int type,

const NotificationSource& source,

const NotificationDetails& details) {

- DCHECK(type == NotificationType::EXTENSION_UNLOADED);

+ DCHECK(type == chrome::NOTIFICATION_EXTENSION_UNLOADED);

Close();

}

Property changes on: chrome\browser\extensions\extension_debugger_api.cc

___________________________________________________________________

Added: svn:eol-style

+ LF