chrome/browser/extensions/crx_installer.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/convert_web_app_browsertest.cc ('k') | chrome/browser/extensions/extension_accessibility_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/crx_installer.cc

===================================================================

--- chrome/browser/extensions/crx_installer.cc (revision 91968)

+++ chrome/browser/extensions/crx_installer.cc (working copy)

@@ -26,12 +26,12 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/shell_integration.h"

#include "chrome/browser/web_applications/web_app.h"

+#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_file_util.h"

#include "content/browser/browser_thread.h"

#include "content/common/notification_service.h"

-#include "content/common/notification_type.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

@@ -438,7 +438,7 @@

// Kill the theme loading bubble.

NotificationService* service = NotificationService::current();

- service->Notify(NotificationType::NO_THEME_DETECTED,

+ service->Notify(chrome::NOTIFICATION_NO_THEME_DETECTED,

Source<CrxInstaller>(this),

NotificationService::NoDetails());

Release(); // balanced in ConfirmInstall().

@@ -511,7 +511,7 @@

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

NotificationService* service = NotificationService::current();

- service->Notify(NotificationType::EXTENSION_INSTALL_ERROR,

+ service->Notify(chrome::NOTIFICATION_EXTENSION_INSTALL_ERROR,

Source<CrxInstaller>(this),

Details<const std::string>(&error));

@@ -572,7 +572,7 @@

// extension before it is unpacked, so they can not filter based

// on the extension.

NotificationService::current()->Notify(

- NotificationType::CRX_INSTALLER_DONE,

+ chrome::NOTIFICATION_CRX_INSTALLER_DONE,

Source<CrxInstaller>(this),

NotificationService::NoDetails());

}