Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4295)

Unified Diff: chrome/browser/download/download_item.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_item.h ('k') | chrome/browser/download/download_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_item.cc
===================================================================
--- chrome/browser/download/download_item.cc (revision 91968)
+++ chrome/browser/download/download_item.cc (working copy)
@@ -28,6 +28,7 @@
#include "chrome/browser/platform_util.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/pref_names.h"
#include "content/browser/browser_thread.h"
@@ -462,7 +463,7 @@
// will call Completed() on this item. If this DownloadItem is not
// around when CRX_INSTALLER_DONE fires, Complete() will not be called.
registrar_.Add(this,
- NotificationType::CRX_INSTALLER_DONE,
+ chrome::NOTIFICATION_CRX_INSTALLER_DONE,
Source<CrxInstaller>(crx_installer.get()));
// The status text and percent complete indicator will change now
@@ -472,17 +473,17 @@
}
// NotificationObserver implementation.
-void DownloadItem::Observe(NotificationType type,
+void DownloadItem::Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) {
// TODO(rdsmith): Change to DCHECK after http://crbug.com/85408 resolved.
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- DCHECK(type == NotificationType::CRX_INSTALLER_DONE);
+ DCHECK(type == chrome::NOTIFICATION_CRX_INSTALLER_DONE);
// No need to listen for CRX_INSTALLER_DONE anymore.
registrar_.Remove(this,
- NotificationType::CRX_INSTALLER_DONE,
+ chrome::NOTIFICATION_CRX_INSTALLER_DONE,
source);
auto_opened_ = true;
« no previous file with comments | « chrome/browser/download/download_item.h ('k') | chrome/browser/download/download_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698