chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

===================================================================

--- chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm (revision 91968)

+++ chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm (working copy)

@@ -10,7 +10,7 @@

#include "chrome/browser/ui/cocoa/browser_window_cocoa.h"

#include "chrome/browser/ui/cocoa/browser_window_controller.h"

#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"

-#include "content/common/notification_type.h"

+#include "chrome/common/chrome_notification_types.h"

#include "testing/gtest/include/gtest/gtest.h"

// A BrowserWindowCocoa that goes PONG when

@@ -25,10 +25,10 @@

}

virtual ~BrowserWindowCocoaPong() { }

- void Observe(NotificationType type,

+ void Observe(int type,

const NotificationSource& source,

const NotificationDetails& details) {

- if (type.value == NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED)

+ if (type == chrome::NOTIFICATION_BOOKMARK_BAR_VISIBILITY_PREF_CHANGED)

pong_ = true;

BrowserWindowCocoa::Observe(type, source, details);

}