chrome/browser/google/google_url_tracker.h - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/google/google_url_tracker.h

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc ('k') | chrome/browser/google/google_url_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/google/google_url_tracker.h

===================================================================

--- chrome/browser/google/google_url_tracker.h (revision 91968)

+++ chrome/browser/google/google_url_tracker.h (working copy)

@@ -89,7 +89,7 @@

const GURL&);

// Registers consumer interest in getting an updated URL from the server.

- // It will be notified as NotificationType::GOOGLE_URL_UPDATED, so the

+ // It will be notified as chrome::GOOGLE_URL_UPDATED, so the

// consumer should observe this notification before calling this.

void SetNeedToFetch();

@@ -114,7 +114,7 @@

const std::string& data);

// NotificationObserver

- virtual void Observe(NotificationType type,

+ virtual void Observe(int type,

const NotificationSource& source,

const NotificationDetails& details);

@@ -125,7 +125,7 @@

void OnNavigationPending(const NotificationSource& source,

const GURL& pending_url);

void OnNavigationCommittedOrTabClosed(TabContents* tab_contents,

- NotificationType::Type type);

+ int type);

void ShowGoogleURLInfoBarIfNecessary(TabContents* tab_contents);

NotificationRegistrar registrar_;

@@ -147,7 +147,7 @@

// updated URL. If this is never set, we won't

// bother to fetch anything.

// Consumers should observe

- // NotificationType::GOOGLE_URL_UPDATED.

+ // chrome::GOOGLE_URL_UPDATED.

bool need_to_prompt_; // True if the last fetched Google URL is not

// matched with current user's default Google URL

// nor the last prompted Google URL.