chrome/browser/extensions/extension_webnavigation_api.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webnavigation_api.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_webnavigation_api.h ('k') | chrome/browser/extensions/extension_webstore_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_webnavigation_api.cc

===================================================================

--- chrome/browser/extensions/extension_webnavigation_api.cc (revision 91968)

+++ chrome/browser/extensions/extension_webnavigation_api.cc (working copy)

@@ -255,17 +255,17 @@

void ExtensionWebNavigationEventRouter::Init() {

if (registrar_.IsEmpty()) {

registrar_.Add(this,

- NotificationType::CREATING_NEW_WINDOW,

+ content::NOTIFICATION_CREATING_NEW_WINDOW,

NotificationService::AllSources());

}

void ExtensionWebNavigationEventRouter::Observe(

- NotificationType type,

+ int type,

const NotificationSource& source,

const NotificationDetails& details) {

- switch (type.value) {

- case NotificationType::CREATING_NEW_WINDOW:

+ switch (type) {

+ case content::NOTIFICATION_CREATING_NEW_WINDOW:

CreatingNewWindow(

Source<TabContents>(source).ptr(),

Details<const ViewHostMsg_CreateWindow_Params>(details).ptr());