chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

===================================================================

--- chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc (revision 91968)

+++ chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc (working copy)

@@ -15,6 +15,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/views/bubble/bubble.h"

+#include "chrome/common/chrome_notification_types.h"

#include "content/browser/user_metrics.h"

#include "content/common/notification_service.h"

#include "grit/generated_resources.h"

@@ -104,7 +105,7 @@

bubble->SizeToContents();

GURL url_ptr(url);

NotificationService::current()->Notify(

- NotificationType::BOOKMARK_BUBBLE_SHOWN,

+ chrome::NOTIFICATION_BOOKMARK_BUBBLE_SHOWN,

Source<Profile>(profile->GetOriginalProfile()),

Details<GURL>(&url_ptr));

bookmark_bubble_->BubbleShown();

@@ -325,7 +326,7 @@

if (delegate_)

delegate_->BubbleClosing(bubble, closed_by_escape);

NotificationService::current()->Notify(

- NotificationType::BOOKMARK_BUBBLE_HIDDEN,

+ chrome::NOTIFICATION_BOOKMARK_BUBBLE_HIDDEN,

Source<Profile>(profile_->GetOriginalProfile()),

NotificationService::NoDetails());

}