Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1690)

Unified Diff: chrome/browser/bookmarks/bookmark_storage.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_storage.h ('k') | chrome/browser/bookmarks/bookmark_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_storage.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_storage.cc (revision 91968)
+++ chrome/browser/bookmarks/bookmark_storage.cc (working copy)
@@ -13,10 +13,10 @@
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_constants.h"
+#include "chrome/common/chrome_notification_types.h"
#include "content/browser/browser_thread.h"
#include "content/common/json_value_serializer.h"
#include "content/common/notification_source.h"
-#include "content/common/notification_type.h"
using base::TimeTicks;
@@ -174,7 +174,7 @@
}
if (!history->BackendLoaded()) {
// The backend isn't finished loading. Wait for it.
- notification_registrar_.Add(this, NotificationType::HISTORY_LOADED,
+ notification_registrar_.Add(this, chrome::NOTIFICATION_HISTORY_LOADED,
Source<Profile>(profile_));
} else {
DoLoadBookmarks(tmp_history_path_);
@@ -182,7 +182,7 @@
}
void BookmarkStorage::OnHistoryFinishedWriting() {
- notification_registrar_.Remove(this, NotificationType::HISTORY_LOADED,
+ notification_registrar_.Remove(this, chrome::NOTIFICATION_HISTORY_LOADED,
Source<Profile>(profile_));
// This is used when migrating bookmarks data from database to file.
@@ -241,11 +241,11 @@
}
}
-void BookmarkStorage::Observe(NotificationType type,
+void BookmarkStorage::Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) {
- switch (type.value) {
- case NotificationType::HISTORY_LOADED:
+ switch (type) {
+ case chrome::NOTIFICATION_HISTORY_LOADED:
OnHistoryFinishedWriting();
break;
« no previous file with comments | « chrome/browser/bookmarks/bookmark_storage.h ('k') | chrome/browser/bookmarks/bookmark_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698