Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/background/background_application_list_model.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_application_list_model.cc
===================================================================
--- chrome/browser/background/background_application_list_model.cc (revision 91968)
+++ chrome/browser/background/background_application_list_model.cc (working copy)
@@ -16,6 +16,7 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/image_loading_tracker.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_resource.h"
#include "content/common/notification_details.h"
@@ -153,13 +154,13 @@
: profile_(profile) {
DCHECK(profile_);
registrar_.Add(this,
- NotificationType::EXTENSION_LOADED,
+ chrome::NOTIFICATION_EXTENSION_LOADED,
Source<Profile>(profile));
registrar_.Add(this,
- NotificationType::EXTENSION_UNLOADED,
+ chrome::NOTIFICATION_EXTENSION_UNLOADED,
Source<Profile>(profile));
registrar_.Add(this,
- NotificationType::EXTENSIONS_READY,
+ chrome::NOTIFICATION_EXTENSIONS_READY,
Source<Profile>(profile));
ExtensionService* service = profile->GetExtensionService();
if (service && service->is_ready())
@@ -249,10 +250,10 @@
}
void BackgroundApplicationListModel::Observe(
- NotificationType type,
+ int type,
const NotificationSource& source,
const NotificationDetails& details) {
- if (type == NotificationType::EXTENSIONS_READY) {
+ if (type == chrome::NOTIFICATION_EXTENSIONS_READY) {
Update();
return;
}
@@ -260,11 +261,11 @@
if (!service || !service->is_ready())
return;
- switch (type.value) {
- case NotificationType::EXTENSION_LOADED:
+ switch (type) {
+ case chrome::NOTIFICATION_EXTENSION_LOADED:
OnExtensionLoaded(Details<Extension>(details).ptr());
break;
- case NotificationType::EXTENSION_UNLOADED:
+ case chrome::NOTIFICATION_EXTENSION_UNLOADED:
OnExtensionUnloaded(Details<UnloadedExtensionInfo>(details)->extension);
break;
default:

Powered by Google App Engine
This is Rietveld 408576698