Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: chrome/browser/extensions/extension_management_browsertest.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_browsertest.cc
===================================================================
--- chrome/browser/extensions/extension_management_browsertest.cc (revision 91968)
+++ chrome/browser/extensions/extension_management_browsertest.cc (working copy)
@@ -15,6 +15,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
+#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/ui_test_utils.h"
@@ -234,10 +235,10 @@
class NotificationListener : public NotificationObserver {
public:
NotificationListener() : started_(false), finished_(false) {
- NotificationType::Type types[] = {
- NotificationType::EXTENSION_UPDATING_STARTED,
- NotificationType::EXTENSION_UPDATING_FINISHED,
- NotificationType::EXTENSION_UPDATE_FOUND
+ int types[] = {
+ chrome::NOTIFICATION_EXTENSION_UPDATING_STARTED,
+ chrome::NOTIFICATION_EXTENSION_UPDATING_FINISHED,
+ chrome::NOTIFICATION_EXTENSION_UPDATE_FOUND
};
for (size_t i = 0; i < arraysize(types); i++) {
registrar_.Add(this, types[i], NotificationService::AllSources());
@@ -258,21 +259,21 @@
}
// Implements NotificationObserver interface.
- virtual void Observe(NotificationType type,
+ virtual void Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) {
- switch (type.value) {
- case NotificationType::EXTENSION_UPDATING_STARTED: {
+ switch (type) {
+ case chrome::NOTIFICATION_EXTENSION_UPDATING_STARTED: {
DCHECK(!started_);
started_ = true;
break;
}
- case NotificationType::EXTENSION_UPDATING_FINISHED: {
+ case chrome::NOTIFICATION_EXTENSION_UPDATING_FINISHED: {
DCHECK(!finished_);
finished_ = true;
break;
}
- case NotificationType::EXTENSION_UPDATE_FOUND: {
+ case chrome::NOTIFICATION_EXTENSION_UPDATE_FOUND: {
const std::string* id = Details<const std::string>(details).ptr();
updates_.insert(*id);
break;
« no previous file with comments | « chrome/browser/extensions/extension_management_apitest.cc ('k') | chrome/browser/extensions/extension_menu_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698