Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_pref_provider.cc
===================================================================
--- chrome/browser/content_settings/content_settings_pref_provider.cc (revision 91968)
+++ chrome/browser/content_settings/content_settings_pref_provider.cc (working copy)
@@ -17,6 +17,7 @@
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/prefs/scoped_user_pref_update.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/content_settings.h"
#include "chrome/common/pref_names.h"
@@ -172,7 +173,7 @@
pref_change_registrar_.Init(prefs);
pref_change_registrar_.Add(prefs::kDefaultContentSettings, this);
- notification_registrar_.Add(this, NotificationType::PROFILE_DESTROYED,
+ notification_registrar_.Add(this, chrome::NOTIFICATION_PROFILE_DESTROYED,
Source<Profile>(profile_));
initializing_ = false;
}
@@ -233,12 +234,12 @@
return false;
}
-void PrefDefaultProvider::Observe(NotificationType type,
+void PrefDefaultProvider::Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- if (type == NotificationType::PREF_CHANGED) {
+ if (type == chrome::NOTIFICATION_PREF_CHANGED) {
DCHECK_EQ(profile_->GetPrefs(), Source<PrefService>(source).ptr());
if (updating_preferences_)
return;
@@ -258,7 +259,7 @@
std::string());
NotifyObservers(details);
}
- } else if (type == NotificationType::PROFILE_DESTROYED) {
+ } else if (type == chrome::NOTIFICATION_PROFILE_DESTROYED) {
DCHECK_EQ(profile_, Source<Profile>(source).ptr());
UnregisterObservers();
} else {
@@ -271,7 +272,7 @@
if (!profile_)
return;
pref_change_registrar_.RemoveAll();
- notification_registrar_.Remove(this, NotificationType::PROFILE_DESTROYED,
+ notification_registrar_.Remove(this, chrome::NOTIFICATION_PROFILE_DESTROYED,
Source<Profile>(profile_));
profile_ = NULL;
}
@@ -337,7 +338,7 @@
if (initializing_ || profile_ == NULL)
return;
NotificationService::current()->Notify(
- NotificationType::CONTENT_SETTINGS_CHANGED,
+ chrome::NOTIFICATION_CONTENT_SETTINGS_CHANGED,
Source<HostContentSettingsMap>(profile_->GetHostContentSettingsMap()),
Details<const ContentSettingsDetails>(&details));
}
@@ -433,7 +434,7 @@
pref_change_registrar_.Add(prefs::kContentSettingsPatterns, this);
pref_change_registrar_.Add(prefs::kContentSettingsPatternPairs, this);
- notification_registrar_.Add(this, NotificationType::PROFILE_DESTROYED,
+ notification_registrar_.Add(this, chrome::NOTIFICATION_PROFILE_DESTROYED,
Source<Profile>(profile_));
initializing_ = false;
}
@@ -575,12 +576,12 @@
}
void PrefProvider::Observe(
- NotificationType type,
+ int type,
const NotificationSource& source,
const NotificationDetails& details) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- if (type == NotificationType::PREF_CHANGED) {
+ if (type == chrome::NOTIFICATION_PREF_CHANGED) {
DCHECK_EQ(profile_->GetPrefs(), Source<PrefService>(source).ptr());
if (updating_preferences_)
return;
@@ -606,7 +607,7 @@
std::string());
NotifyObservers(details);
}
- } else if (type == NotificationType::PROFILE_DESTROYED) {
+ } else if (type == chrome::NOTIFICATION_PROFILE_DESTROYED) {
DCHECK_EQ(profile_, Source<Profile>(source).ptr());
UnregisterObservers();
} else {
@@ -923,7 +924,7 @@
if (initializing_ || profile_ == NULL)
return;
NotificationService::current()->Notify(
- NotificationType::CONTENT_SETTINGS_CHANGED,
+ chrome::NOTIFICATION_CONTENT_SETTINGS_CHANGED,
Source<HostContentSettingsMap>(
profile_->GetHostContentSettingsMap()),
Details<const ContentSettingsDetails>(&details));
@@ -934,7 +935,7 @@
if (!profile_)
return;
pref_change_registrar_.RemoveAll();
- notification_registrar_.Remove(this, NotificationType::PROFILE_DESTROYED,
+ notification_registrar_.Remove(this, chrome::NOTIFICATION_PROFILE_DESTROYED,
Source<Profile>(profile_));
profile_ = NULL;
}

Powered by Google App Engine
This is Rietveld 408576698