chrome/browser/task_manager/task_manager_browsertest.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_browsertest.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tabs/tab_strip_model_unittest.cc ('k') | chrome/browser/task_manager/task_manager_notification_resource_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager_browsertest.cc

===================================================================

--- chrome/browser/task_manager/task_manager_browsertest.cc (revision 91968)

+++ chrome/browser/task_manager/task_manager_browsertest.cc (working copy)

@@ -22,6 +22,7 @@

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

+#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/test/in_process_browser_test.h"

#include "chrome/test/ui_test_utils.h"

@@ -83,14 +84,14 @@

class BackgroundContentsListener : public NotificationObserver {

public:

explicit BackgroundContentsListener(Profile* profile) {

- registrar_.Add(this, NotificationType::BACKGROUND_CONTENTS_NAVIGATED,

+ registrar_.Add(this, chrome::NOTIFICATION_BACKGROUND_CONTENTS_NAVIGATED,

Source<Profile>(profile));

}

- virtual void Observe(NotificationType type,

+ virtual void Observe(int type,

const NotificationSource& source,

const NotificationDetails& details) {

// Quit once the BackgroundContents has been loaded.

- if (type.value == NotificationType::BACKGROUND_CONTENTS_NAVIGATED)

+ if (type == chrome::NOTIFICATION_BACKGROUND_CONTENTS_NAVIGATED)

MessageLoopForUI::current()->Quit();

}

private: