Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/sidebar/sidebar_manager.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sidebar/sidebar_manager.h ('k') | chrome/browser/speech/speech_input_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sidebar/sidebar_manager.cc
===================================================================
--- chrome/browser/sidebar/sidebar_manager.cc (revision 91968)
+++ chrome/browser/sidebar/sidebar_manager.cc (working copy)
@@ -11,6 +11,7 @@
#include "chrome/browser/extensions/extension_sidebar_api.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sidebar/sidebar_container.h"
+#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_switches.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "content/common/notification_service.h"
@@ -219,10 +220,10 @@
DCHECK(sidebar_host_to_tab_.empty());
}
-void SidebarManager::Observe(NotificationType type,
+void SidebarManager::Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) {
- if (type == NotificationType::TAB_CONTENTS_DESTROYED) {
+ if (type == content::NOTIFICATION_TAB_CONTENTS_DESTROYED) {
HideAllSidebars(Source<TabContents>(source).ptr());
} else {
NOTREACHED() << "Got a notification we didn't register for!";
@@ -231,7 +232,7 @@
void SidebarManager::UpdateSidebar(SidebarContainer* host) {
NotificationService::current()->Notify(
- NotificationType::SIDEBAR_CHANGED,
+ chrome::NOTIFICATION_SIDEBAR_CHANGED,
Source<SidebarManager>(this),
Details<SidebarContainer>(host));
}
@@ -273,7 +274,7 @@
// If it's a first sidebar for this tab, register destroy notification.
if (tab_to_sidebar_host_.find(tab) == tab_to_sidebar_host_.end()) {
registrar_.Add(this,
- NotificationType::TAB_CONTENTS_DESTROYED,
+ content::NOTIFICATION_TAB_CONTENTS_DESTROYED,
Source<TabContents>(tab));
}
@@ -292,7 +293,7 @@
// If there's no more sidebars linked to this tab, unsubscribe.
if (tab_to_sidebar_host_.find(tab) == tab_to_sidebar_host_.end()) {
registrar_.Remove(this,
- NotificationType::TAB_CONTENTS_DESTROYED,
+ content::NOTIFICATION_TAB_CONTENTS_DESTROYED,
Source<TabContents>(tab));
}
« no previous file with comments | « chrome/browser/sidebar/sidebar_manager.h ('k') | chrome/browser/speech/speech_input_bubble_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698