Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3482)

Unified Diff: chrome/browser/ui/views/notifications/balloon_view.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/notifications/balloon_view.cc
===================================================================
--- chrome/browser/ui/views/notifications/balloon_view.cc (revision 91771)
+++ chrome/browser/ui/views/notifications/balloon_view.cc (working copy)
@@ -15,6 +15,7 @@
#include "chrome/browser/notifications/notification_options_menu_model.h"
#include "chrome/browser/ui/views/bubble/bubble_border.h"
#include "chrome/browser/ui/views/notifications/balloon_view_host.h"
+#include "chrome/common/chrome_notification_types.h"
#include "content/browser/renderer_host/render_view_host.h"
#include "content/browser/renderer_host/render_widget_host_view.h"
#include "content/common/notification_details.h"
@@ -358,7 +359,7 @@
frame_container_->Show();
notification_registrar_.Add(this,
- NotificationType::NOTIFY_BALLOON_DISCONNECTED, Source<Balloon>(balloon));
+ chrome::NOTIFY_BALLOON_DISCONNECTED, Source<Balloon>(balloon));
}
void BalloonViewImpl::RunOptionsMenu(const gfx::Point& pt) {
@@ -491,7 +492,7 @@
void BalloonViewImpl::Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details) {
- if (type != NotificationType::NOTIFY_BALLOON_DISCONNECTED) {
+ if (type != chrome::NOTIFY_BALLOON_DISCONNECTED) {
NOTREACHED();
return;
}
@@ -499,6 +500,6 @@
// If the renderer process attached to this balloon is disconnected
// (e.g., because of a crash), we want to close the balloon.
notification_registrar_.Remove(this,
- NotificationType::NOTIFY_BALLOON_DISCONNECTED, Source<Balloon>(balloon_));
+ chrome::NOTIFY_BALLOON_DISCONNECTED, Source<Balloon>(balloon_));
Close(false);
}

Powered by Google App Engine
This is Rietveld 408576698