chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/accessibility_event_router_views_unittest.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc » ('j') | chrome/common/chrome_notification_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

===================================================================

--- chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (revision 91771)

+++ chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (working copy)

@@ -30,6 +30,7 @@

#include "chrome/browser/ui/views/event_utils.h"

#include "chrome/browser/ui/views/frame/browser_view.h"

#include "chrome/browser/ui/views/location_bar/location_bar_view.h"

+#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/pref_names.h"

@@ -420,8 +421,8 @@

other_bookmarked_button_->SetEnabled(false);

Source<Profile> ns_source(profile_->GetOriginalProfile());

- registrar_.Add(this, NotificationType::BOOKMARK_BUBBLE_SHOWN, ns_source);

- registrar_.Add(this, NotificationType::BOOKMARK_BUBBLE_HIDDEN, ns_source);

+ registrar_.Add(this, chrome::BOOKMARK_BUBBLE_SHOWN, ns_source);

+ registrar_.Add(this, chrome::BOOKMARK_BUBBLE_HIDDEN, ns_source);

// Remove any existing bookmark buttons.

while (GetBookmarkButtonCount())

@@ -1142,7 +1143,7 @@

const NotificationDetails& details) {

DCHECK(profile_);

switch (type.value) {

- case NotificationType::BOOKMARK_BUBBLE_SHOWN: {

+ case chrome::BOOKMARK_BUBBLE_SHOWN: {

StopThrobbing(true);

GURL url = *(Details<GURL>(details).ptr());

const BookmarkNode* node = model_->GetMostRecentlyAddedNodeForURL(url);

@@ -1151,7 +1152,7 @@

StartThrobbing(node, false);

break;

}

- case NotificationType::BOOKMARK_BUBBLE_HIDDEN:

+ case chrome::BOOKMARK_BUBBLE_HIDDEN:

StopThrobbing(false);

break;