Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Unified Diff: chrome/browser/extensions/extensions_ui.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_ui.cc
===================================================================
--- chrome/browser/extensions/extensions_ui.cc (revision 91771)
+++ chrome/browser/extensions/extensions_ui.cc (working copy)
@@ -28,6 +28,7 @@
#include "chrome/browser/tab_contents/background_contents.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/webui/extension_icon_source.h"
+#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_icon_set.h"
#include "chrome/common/extensions/url_pattern.h"
@@ -290,13 +291,13 @@
void ExtensionsDOMHandler::RegisterForNotifications() {
// Register for notifications that we need to reload the page.
- registrar_.Add(this, NotificationType::EXTENSION_LOADED,
+ registrar_.Add(this, chrome::EXTENSION_LOADED,
NotificationService::AllSources());
- registrar_.Add(this, NotificationType::EXTENSION_PROCESS_CREATED,
+ registrar_.Add(this, chrome::EXTENSION_PROCESS_CREATED,
NotificationService::AllSources());
- registrar_.Add(this, NotificationType::EXTENSION_UNLOADED,
+ registrar_.Add(this, chrome::EXTENSION_UNLOADED,
NotificationService::AllSources());
- registrar_.Add(this, NotificationType::EXTENSION_UPDATE_DISABLED,
+ registrar_.Add(this, chrome::EXTENSION_UPDATE_DISABLED,
NotificationService::AllSources());
registrar_.Add(this,
NotificationType::NAV_ENTRY_COMMITTED,
@@ -308,13 +309,13 @@
NotificationType::RENDER_VIEW_HOST_DELETED,
NotificationService::AllSources());
registrar_.Add(this,
- NotificationType::BACKGROUND_CONTENTS_NAVIGATED,
+ chrome::BACKGROUND_CONTENTS_NAVIGATED,
NotificationService::AllSources());
registrar_.Add(this,
- NotificationType::BACKGROUND_CONTENTS_DELETED,
+ chrome::BACKGROUND_CONTENTS_DELETED,
NotificationService::AllSources());
registrar_.Add(this,
- NotificationType::EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,
+ chrome::EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,
NotificationService::AllSources());
}
@@ -639,18 +640,18 @@
deleting_rvh_ = Source<RenderViewHost>(source).ptr();
MaybeUpdateAfterNotification();
break;
- case NotificationType::BACKGROUND_CONTENTS_DELETED:
+ case chrome::BACKGROUND_CONTENTS_DELETED:
deleting_rvh_ = Details<BackgroundContents>(details)->render_view_host();
MaybeUpdateAfterNotification();
break;
- case NotificationType::EXTENSION_LOADED:
- case NotificationType::EXTENSION_PROCESS_CREATED:
- case NotificationType::EXTENSION_UNLOADED:
- case NotificationType::EXTENSION_UPDATE_DISABLED:
+ case chrome::EXTENSION_LOADED:
+ case chrome::EXTENSION_PROCESS_CREATED:
+ case chrome::EXTENSION_UNLOADED:
+ case chrome::EXTENSION_UPDATE_DISABLED:
case NotificationType::RENDER_VIEW_HOST_CREATED:
case NotificationType::NAV_ENTRY_COMMITTED:
- case NotificationType::BACKGROUND_CONTENTS_NAVIGATED:
- case NotificationType::EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED:
+ case chrome::BACKGROUND_CONTENTS_NAVIGATED:
+ case chrome::EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED:
MaybeUpdateAfterNotification();
break;
default:

Powered by Google App Engine
This is Rietveld 408576698