chrome/browser/chromeos/notifications/balloon_view.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/notifications/balloon_view.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/notifications/balloon_collection_impl.cc ('k') | chrome/browser/chromeos/notifications/notification_browsertest.cc » ('j') | chrome/common/chrome_notification_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/notifications/balloon_view.cc

===================================================================

--- chrome/browser/chromeos/notifications/balloon_view.cc (revision 91771)

+++ chrome/browser/chromeos/notifications/balloon_view.cc (working copy)

@@ -216,7 +216,7 @@

html_contents_->EnableWebUI();

AddChildView(html_contents_->view());

notification_registrar_.Add(this,

- NotificationType::NOTIFY_BALLOON_DISCONNECTED, Source<Balloon>(balloon));

+ chrome::NOTIFY_BALLOON_DISCONNECTED, Source<Balloon>(balloon));

}

void BalloonViewImpl::Update() {

@@ -290,7 +290,7 @@

void BalloonViewImpl::Observe(NotificationType type,

const NotificationSource& source,

const NotificationDetails& details) {

- if (type != NotificationType::NOTIFY_BALLOON_DISCONNECTED) {

+ if (type != chrome::NOTIFY_BALLOON_DISCONNECTED) {

NOTREACHED();

return;

}

@@ -298,7 +298,7 @@

// If the renderer process attached to this balloon is disconnected

// (e.g., because of a crash), we want to close the balloon.

notification_registrar_.Remove(this,

- NotificationType::NOTIFY_BALLOON_DISCONNECTED, Source<Balloon>(balloon_));

+ chrome::NOTIFY_BALLOON_DISCONNECTED, Source<Balloon>(balloon_));

Close(false);

}