chrome/browser/browser_browsertest.cc - Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_browsertest.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_browsertest.cc

===================================================================

--- chrome/browser/browser_browsertest.cc (revision 91771)

+++ chrome/browser/browser_browsertest.cc (working copy)

@@ -26,6 +26,7 @@

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

+#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/url_constants.h"

@@ -35,7 +36,6 @@

#include "content/browser/renderer_host/render_view_host.h"

#include "content/browser/tab_contents/tab_contents.h"

#include "content/common/notification_source.h"

-#include "content/common/notification_type.h"

#include "content/common/page_transition_types.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

@@ -612,7 +612,7 @@

Source<TabContents> source(current_tab);

ui_test_utils::WindowedNotificationObserverWithDetails<std::string>

- en_language_detected_signal(NotificationType::TAB_LANGUAGE_DETERMINED,

+ en_language_detected_signal(chrome::TAB_LANGUAGE_DETERMINED,

source);

EXPECT_EQ("", helper->language_state().original_language());

en_language_detected_signal.Wait();

@@ -623,7 +623,7 @@

// Now navigate to a page in French.

ui_test_utils::WindowedNotificationObserverWithDetails<std::string>

- fr_language_detected_signal(NotificationType::TAB_LANGUAGE_DETERMINED,

+ fr_language_detected_signal(chrome::TAB_LANGUAGE_DETERMINED,

source);

ui_test_utils::NavigateToURL(

browser(), GURL(test_server()->GetURL("files/french_page.html")));

« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils.cc ('k') | chrome/browser/browser_focus_uitest.cc » ('j') | chrome/common/chrome_notification_types.h » ('J')