Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: chrome/browser/ui/gtk/global_menu_bar.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/gtk/global_menu_bar.h ('k') | chrome/browser/ui/gtk/gtk_theme_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/global_menu_bar.h" 5 #include "chrome/browser/ui/gtk/global_menu_bar.h"
6 6
7 #include <gtk/gtk.h> 7 #include <gtk/gtk.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "chrome/app/chrome_command_ids.h" 10 #include "chrome/app/chrome_command_ids.h"
11 #include "chrome/browser/prefs/pref_service.h" 11 #include "chrome/browser/prefs/pref_service.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
14 #include "chrome/browser/ui/gtk/accelerators_gtk.h" 14 #include "chrome/browser/ui/gtk/accelerators_gtk.h"
15 #include "chrome/browser/ui/gtk/gtk_theme_service.h" 15 #include "chrome/browser/ui/gtk/gtk_theme_service.h"
16 #include "chrome/browser/ui/gtk/gtk_util.h" 16 #include "chrome/browser/ui/gtk/gtk_util.h"
17 #include "chrome/common/chrome_notification_types.h"
17 #include "chrome/common/chrome_switches.h" 18 #include "chrome/common/chrome_switches.h"
18 #include "chrome/common/pref_names.h" 19 #include "chrome/common/pref_names.h"
19 #include "content/common/notification_service.h" 20 #include "content/common/notification_service.h"
20 #include "grit/generated_resources.h" 21 #include "grit/generated_resources.h"
21 #include "ui/base/l10n/l10n_util.h" 22 #include "ui/base/l10n/l10n_util.h"
22 #include "ui/gfx/gtk_util.h" 23 #include "ui/gfx/gtk_util.h"
23 24
24 struct GlobalMenuBarCommand { 25 struct GlobalMenuBarCommand {
25 int str_id; 26 int str_id;
26 int command; 27 int command;
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 dummy_accel_group_, 207 dummy_accel_group_,
207 accelerator_gtk->GetGdkKeyCode(), 208 accelerator_gtk->GetGdkKeyCode(),
208 accelerator_gtk->gdk_modifier_type(), 209 accelerator_gtk->gdk_modifier_type(),
209 GTK_ACCEL_VISIBLE); 210 GTK_ACCEL_VISIBLE);
210 } 211 }
211 212
212 browser_->command_updater()->AddCommandObserver(it->first, this); 213 browser_->command_updater()->AddCommandObserver(it->first, this);
213 } 214 }
214 215
215 // Listen for bookmark bar visibility changes and set the initial state. 216 // Listen for bookmark bar visibility changes and set the initial state.
216 registrar_.Add(this, NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED, 217 registrar_.Add(this,
218 chrome::NOTIFICATION_BOOKMARK_BAR_VISIBILITY_PREF_CHANGED,
217 NotificationService::AllSources()); 219 NotificationService::AllSources());
218 Observe(NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED, 220 Observe(chrome::NOTIFICATION_BOOKMARK_BAR_VISIBILITY_PREF_CHANGED,
219 NotificationService::AllSources(), 221 NotificationService::AllSources(),
220 NotificationService::NoDetails()); 222 NotificationService::NoDetails());
221 } 223 }
222 224
223 GlobalMenuBar::~GlobalMenuBar() { 225 GlobalMenuBar::~GlobalMenuBar() {
224 for (CommandIDMenuItemMap::const_iterator it = id_to_menu_item_.begin(); 226 for (CommandIDMenuItemMap::const_iterator it = id_to_menu_item_.begin();
225 it != id_to_menu_item_.end(); ++it) { 227 it != id_to_menu_item_.end(); ++it) {
226 browser_->command_updater()->RemoveCommandObserver(it->first, this); 228 browser_->command_updater()->RemoveCommandObserver(it->first, this);
227 } 229 }
228 230
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 gtk_widget_show(menu_item); 297 gtk_widget_show(menu_item);
296 return menu_item; 298 return menu_item;
297 } 299 }
298 300
299 void GlobalMenuBar::EnabledStateChangedForCommand(int id, bool enabled) { 301 void GlobalMenuBar::EnabledStateChangedForCommand(int id, bool enabled) {
300 CommandIDMenuItemMap::iterator it = id_to_menu_item_.find(id); 302 CommandIDMenuItemMap::iterator it = id_to_menu_item_.find(id);
301 if (it != id_to_menu_item_.end()) 303 if (it != id_to_menu_item_.end())
302 gtk_widget_set_sensitive(it->second, enabled); 304 gtk_widget_set_sensitive(it->second, enabled);
303 } 305 }
304 306
305 void GlobalMenuBar::Observe(NotificationType type, 307 void GlobalMenuBar::Observe(int type,
306 const NotificationSource& source, 308 const NotificationSource& source,
307 const NotificationDetails& details) { 309 const NotificationDetails& details) {
308 DCHECK(type.value == NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED); 310 DCHECK(type == chrome::NOTIFICATION_BOOKMARK_BAR_VISIBILITY_PREF_CHANGED);
309 311
310 CommandIDMenuItemMap::iterator it = 312 CommandIDMenuItemMap::iterator it =
311 id_to_menu_item_.find(IDC_SHOW_BOOKMARK_BAR); 313 id_to_menu_item_.find(IDC_SHOW_BOOKMARK_BAR);
312 if (it != id_to_menu_item_.end()) { 314 if (it != id_to_menu_item_.end()) {
313 PrefService* prefs = browser_->profile()->GetPrefs(); 315 PrefService* prefs = browser_->profile()->GetPrefs();
314 316
315 block_activation_ = true; 317 block_activation_ = true;
316 gtk_check_menu_item_set_active( 318 gtk_check_menu_item_set_active(
317 GTK_CHECK_MENU_ITEM(it->second), 319 GTK_CHECK_MENU_ITEM(it->second),
318 prefs->GetBoolean(prefs::kShowBookmarkBar)); 320 prefs->GetBoolean(prefs::kShowBookmarkBar));
319 block_activation_ = false; 321 block_activation_ = false;
320 } 322 }
321 } 323 }
322 324
323 void GlobalMenuBar::OnItemActivated(GtkWidget* sender) { 325 void GlobalMenuBar::OnItemActivated(GtkWidget* sender) {
324 if (block_activation_) 326 if (block_activation_)
325 return; 327 return;
326 328
327 int id = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(sender), "command-id")); 329 int id = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(sender), "command-id"));
328 browser_->ExecuteCommandIfEnabled(id); 330 browser_->ExecuteCommandIfEnabled(id);
329 } 331 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/global_menu_bar.h ('k') | chrome/browser/ui/gtk/gtk_theme_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698