Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/browser/ui/gtk/global_history_menu.cc

Issue 7327007: Moving notification types which are chrome specific to a new header file chrome_notification_type... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/gtk/global_history_menu.h ('k') | chrome/browser/ui/gtk/global_menu_bar.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/global_history_menu.h" 5 #include "chrome/browser/ui/gtk/global_history_menu.h"
6 6
7 #include <gtk/gtk.h> 7 #include <gtk/gtk.h>
8 8
9 #include "base/stl_util-inl.h" 9 #include "base/stl_util-inl.h"
10 #include "base/string_number_conversions.h" 10 #include "base/string_number_conversions.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/browser/history/top_sites.h" 12 #include "chrome/browser/history/top_sites.h"
13 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/sessions/tab_restore_service.h" 14 #include "chrome/browser/sessions/tab_restore_service.h"
15 #include "chrome/browser/sessions/tab_restore_service_factory.h" 15 #include "chrome/browser/sessions/tab_restore_service_factory.h"
16 #include "chrome/browser/themes/theme_service_factory.h" 16 #include "chrome/browser/themes/theme_service_factory.h"
17 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/browser_tab_restore_service_delegate.h" 18 #include "chrome/browser/ui/browser_tab_restore_service_delegate.h"
19 #include "chrome/browser/ui/gtk/global_menu_bar.h" 19 #include "chrome/browser/ui/gtk/global_menu_bar.h"
20 #include "chrome/browser/ui/gtk/gtk_theme_service.h" 20 #include "chrome/browser/ui/gtk/gtk_theme_service.h"
21 #include "chrome/browser/ui/gtk/gtk_util.h" 21 #include "chrome/browser/ui/gtk/gtk_util.h"
22 #include "chrome/browser/ui/gtk/owned_widget_gtk.h" 22 #include "chrome/browser/ui/gtk/owned_widget_gtk.h"
23 #include "chrome/common/chrome_notification_types.h"
23 #include "chrome/common/url_constants.h" 24 #include "chrome/common/url_constants.h"
24 #include "content/common/notification_service.h" 25 #include "content/common/notification_service.h"
25 #include "grit/generated_resources.h" 26 #include "grit/generated_resources.h"
26 #include "ui/base/l10n/l10n_util.h" 27 #include "ui/base/l10n/l10n_util.h"
27 #include "ui/base/text/text_elider.h" 28 #include "ui/base/text/text_elider.h"
28 #include "ui/gfx/codec/png_codec.h" 29 #include "ui/gfx/codec/png_codec.h"
29 #include "ui/gfx/gtk_util.h" 30 #include "ui/gfx/gtk_util.h"
30 31
31 namespace { 32 namespace {
32 33
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 g_signal_connect(history_menu_item, "activate", 112 g_signal_connect(history_menu_item, "activate",
112 G_CALLBACK(OnMenuActivateThunk), this); 113 G_CALLBACK(OnMenuActivateThunk), this);
113 114
114 if (profile_) { 115 if (profile_) {
115 top_sites_ = profile_->GetTopSites(); 116 top_sites_ = profile_->GetTopSites();
116 if (top_sites_) { 117 if (top_sites_) {
117 GetTopSitesData(); 118 GetTopSitesData();
118 119
119 // Register for notification when TopSites changes so that we can update 120 // Register for notification when TopSites changes so that we can update
120 // ourself. 121 // ourself.
121 registrar_.Add(this, NotificationType::TOP_SITES_CHANGED, 122 registrar_.Add(this, chrome::NOTIFICATION_TOP_SITES_CHANGED,
122 Source<history::TopSites>(top_sites_)); 123 Source<history::TopSites>(top_sites_));
123 } 124 }
124 } 125 }
125 } 126 }
126 127
127 void GlobalHistoryMenu::GetTopSitesData() { 128 void GlobalHistoryMenu::GetTopSitesData() {
128 DCHECK(top_sites_); 129 DCHECK(top_sites_);
129 130
130 top_sites_->GetMostVisitedURLs( 131 top_sites_->GetMostVisitedURLs(
131 &top_sites_consumer_, 132 &top_sites_consumer_,
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 } 272 }
272 273
273 GtkWidget* submenu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(menu_item)); 274 GtkWidget* submenu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(menu_item));
274 if (submenu) 275 if (submenu)
275 closure->menu_bar->ClearMenuSection(submenu, closure->tag); 276 closure->menu_bar->ClearMenuSection(submenu, closure->tag);
276 277
277 gtk_container_remove(GTK_CONTAINER(closure->container), menu_item); 278 gtk_container_remove(GTK_CONTAINER(closure->container), menu_item);
278 } 279 }
279 } 280 }
280 281
281 void GlobalHistoryMenu::Observe(NotificationType type, 282 void GlobalHistoryMenu::Observe(int type,
282 const NotificationSource& source, 283 const NotificationSource& source,
283 const NotificationDetails& details) { 284 const NotificationDetails& details) {
284 if (type.value == NotificationType::TOP_SITES_CHANGED) { 285 if (type == chrome::NOTIFICATION_TOP_SITES_CHANGED) {
285 if (Source<history::TopSites>(source).ptr() == top_sites_) 286 if (Source<history::TopSites>(source).ptr() == top_sites_)
286 GetTopSitesData(); 287 GetTopSitesData();
287 } else { 288 } else {
288 NOTREACHED(); 289 NOTREACHED();
289 } 290 }
290 } 291 }
291 292
292 void GlobalHistoryMenu::TabRestoreServiceChanged(TabRestoreService* service) { 293 void GlobalHistoryMenu::TabRestoreServiceChanged(TabRestoreService* service) {
293 const TabRestoreService::Entries& entries = service->entries(); 294 const TabRestoreService::Entries& entries = service->entries();
294 295
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 tab_restore_service_->LoadTabsFromLastSession(); 435 tab_restore_service_->LoadTabsFromLastSession();
435 tab_restore_service_->AddObserver(this); 436 tab_restore_service_->AddObserver(this);
436 437
437 // If LoadTabsFromLastSession doesn't load tabs, it won't call 438 // If LoadTabsFromLastSession doesn't load tabs, it won't call
438 // TabRestoreServiceChanged(). This ensures that all new windows after 439 // TabRestoreServiceChanged(). This ensures that all new windows after
439 // the first one will have their menus populated correctly. 440 // the first one will have their menus populated correctly.
440 TabRestoreServiceChanged(tab_restore_service_); 441 TabRestoreServiceChanged(tab_restore_service_);
441 } 442 }
442 } 443 }
443 } 444 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/global_history_menu.h ('k') | chrome/browser/ui/gtk/global_menu_bar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698