Multi-Profiles: Add customize profile menu item

Multi-Profiles: Add customize profile menu item

This change adds a customize profile menu item to the avatar menu. Clicking on the menu item takes the user to the personal options page.

BUG=
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91793

[Robert Sesek, 2011-07-07 20:19:48]

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser/avatar_button.h (right):

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser/avatar_button.h:17: class Browser;
nit: alphabetize without regard to class vs @class

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser/avatar_button.h:39: browser: (Browser*)browser;
nit: no space after :

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser/avatar_button.mm (right):

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser/avatar_button.mm:26: -
(id)initWithController:(BrowserWindowController*)bwc
If you're going to pass the Browser* directly, you can remove the BWC argument
here as well as the controller_ ivar.

[Miranda Callahan, 2011-07-07 20:22:09]

On 2011/07/07 20:19:48, rsesek wrote:
>
http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
> File chrome/browser/ui/cocoa/browser/avatar_button.h (right):
> 
> 

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
> chrome/browser/ui/cocoa/browser/avatar_button.h:17: class Browser;
> nit: alphabetize without regard to class vs @class
> 
>
http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
> chrome/browser/ui/cocoa/browser/avatar_button.h:39: browser:
(Browser*)browser;
> nit: no space after :
> 
>
http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
> File chrome/browser/ui/cocoa/browser/avatar_button.mm (right):
> 
>
http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
> chrome/browser/ui/cocoa/browser/avatar_button.mm:26: -
> (id)initWithController:(BrowserWindowController*)bwc
> If you're going to pass the Browser* directly, you can remove the BWC argument
> here as well as the controller_ ivar.

With rsesek's issues fixed, LGTM.

[sail, 2011-07-07 21:11:23]

http://codereview.chromium.org/7327003/diff/5001/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser/avatar_button.mm (left):

http://codereview.chromium.org/7327003/diff/5001/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser/avatar_button.mm:53: } else if ([controller_
shouldShowAvatar]) {
This button is only created if showShowAvatar is true so I took this out.

[sail, 2011-07-07 21:13:09]

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser/avatar_button.h (right):

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser/avatar_button.h:17: class Browser;
On 2011/07/07 20:19:48, rsesek wrote:
> nit: alphabetize without regard to class vs @class

Done.

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser/avatar_button.h:39: browser: (Browser*)browser;
On 2011/07/07 20:19:48, rsesek wrote:
> nit: no space after :

Done.

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser/avatar_button.mm (right):

http://codereview.chromium.org/7327003/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser/avatar_button.mm:26: -
(id)initWithController:(BrowserWindowController*)bwc
On 2011/07/07 20:19:48, rsesek wrote:
> If you're going to pass the Browser* directly, you can remove the BWC argument
> here as well as the controller_ ivar.

Done.

[Robert Sesek, 2011-07-07 21:14:09]

LGTM