The text color for BookmarkButton sometimes doesn't get updated.

chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h"
 
 #include "base/logging.h"
 #include "base/sys_string_conversions.h"
 #import "chrome/browser/bookmarks/bookmark_model.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_button.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu.h"
 #import "chrome/browser/ui/cocoa/image_utils.h"
 #include "content/browser/user_metrics.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/gfx/mac/nsimage_cache.h"
 
 
 @interface BookmarkButtonCell(Private)
 - (void)configureBookmarkButtonCell;
+- (void)applyTextColor;
 @end
 
 
 @implementation BookmarkButtonCell
 
 @synthesize startingChildIndex = startingChildIndex_;
 @synthesize drawFolderArrow = drawFolderArrow_;
 
 + (id)buttonCellForNode:(const BookmarkNode*)node
             contextMenu:(NSMenu*)contextMenu
                cellText:(NSString*)cellText
               cellImage:(NSImage*)cellImage {
   id buttonCell =
       [[[BookmarkButtonCell alloc] initForNode:node
                                    contextMenu:contextMenu
                                       cellText:cellText
                                      cellImage:cellImage]
        autorelease];
   return buttonCell;
 }
 
 - (id)initForNode:(const BookmarkNode*)node
       contextMenu:(NSMenu*)contextMenu
          cellText:(NSString*)cellText
         cellImage:(NSImage*)cellImage {
   if ((self = [super initTextCell:cellText])) {
     [self configureBookmarkButtonCell];

[John Grabowski, 2011/07/12 02:15:38]

Minor nit: we now have 3 method calls with blank lines between them.
Might be better to remove the blank lines (49 and 51).

 
+    [self setTextColor:[NSColor redColor]];
+
     [self setBookmarkNode:node];
 
     if (node) {
       NSString* title = base::SysUTF16ToNSString(node->GetTitle());
       [self setBookmarkCellText:title image:cellImage];
       [self setMenu:contextMenu];
     } else {
       [self setEmpty:YES];
       [self setBookmarkCellText:l10n_util::GetNSString(IDS_MENU_EMPTY_SUBMENU)
                           image:nil];
@@ skipping 94 matching lines @@
     UserMetrics::RecordAction(UserMetricsAction("BookmarkBarFolder_CtxMenu"));
   } else {
     UserMetrics::RecordAction(UserMetricsAction("BookmarkBar_CtxMenu"));
   }
 
   [menu setRepresentedObject:[NSNumber numberWithLongLong:node->id()]];
 
   return menu;
 }
 
-// Unfortunately, NSCell doesn't already have something like this.
-// TODO(jrg): consider placing in GTM.
+- (void)setTitle:(NSString*)title {
+  if ([[self title] isEqualTo:title])
+    return;
+  [super setTitle:title];
+  [self applyTextColor];
+}
+
 - (void)setTextColor:(NSColor*)color {
+  if ([textColor_ isEqualTo:color])
+    return;
+  textColor_.reset([color copy]);
+  [self applyTextColor];
+}
 
-  // We can't properly set the cell's text color without a control.
-  // In theory we could just save the next for later and wait until
-  // the cell is moved to a control, but there is no obvious way to
-  // accomplish that (e.g. no "cellDidMoveToControl" notification.)
-  DCHECK([self controlView]);
-
+- (void)applyTextColor {

[John Grabowski, 2011/07/12 02:15:38]

Add comment in code explaining why this is here.  E.g. "we must apply the color
after any setTitle call".

   scoped_nsobject<NSMutableParagraphStyle> style([NSMutableParagraphStyle new]);
   [style setAlignment:NSLeftTextAlignment];
   NSDictionary* dict = [NSDictionary
-                         dictionaryWithObjectsAndKeys:color,
+                         dictionaryWithObjectsAndKeys:textColor_,
                          NSForegroundColorAttributeName,
                          [self font], NSFontAttributeName,
                          style.get(), NSParagraphStyleAttributeName,
                          nil];
   scoped_nsobject<NSAttributedString> ats([[NSAttributedString alloc]
                                             initWithString:[self title]
                                                 attributes:dict]);
-  NSButton* button = static_cast<NSButton*>([self controlView]);
-  if (button) {
-    DCHECK([button isKindOfClass:[NSButton class]]);
-    [button setAttributedTitle:ats.get()];
-  }
+  [self setAttributedTitle:ats.get()];
 }
 
 // To implement "hover open a bookmark button to open the folder"
 // which feels like menus, we override NSButtonCell's mouseEntered:
 // and mouseExited:, then and pass them along to our owning control.
 // Note: as verified in a debugger, mouseEntered: does NOT increase
 // the retainCount of the cell or its owning control.
 - (void)mouseEntered:(NSEvent*)event {
   [super mouseEntered:event];
   [[self controlView] mouseEntered:event];
@@ skipping 43 matching lines @@
     NSRect drawRect = NSOffsetRect(imageRect, dX, dY);
     [arrowImage_ drawInRect:drawRect
                     fromRect:imageRect
                    operation:NSCompositeSourceOver
                     fraction:[self isEnabled] ? 1.0 : 0.5
                 neverFlipped:YES];
   }
 }
 
 @end