about://appcache-internals enhancements

net/url_request/view_cache_helper.cc

Index: net/url_request/view_cache_helper.cc
===================================================================
--- net/url_request/view_cache_helper.cc	(revision 91517)
+++ net/url_request/view_cache_helper.cc	(working copy)
@@ -24,43 +24,6 @@
 
 namespace {
 
-void HexDump(const char *buf, size_t buf_len, std::string* result) {
-  const size_t kMaxRows = 16;
-  int offset = 0;
-
-  const unsigned char *p;
-  while (buf_len) {
-    base::StringAppendF(result, "%08x:  ", offset);
-    offset += kMaxRows;
-
-    p = (const unsigned char *) buf;
-
-    size_t i;
-    size_t row_max = std::min(kMaxRows, buf_len);
-
-    // print hex codes:
-    for (i = 0; i < row_max; ++i)
-      base::StringAppendF(result, "%02x  ", *p++);
-    for (i = row_max; i < kMaxRows; ++i)
-      result->append("    ");
-
-    // print ASCII glyphs if possible:
-    p = (const unsigned char *) buf;
-    for (i = 0; i < row_max; ++i, ++p) {
-      if (*p < 0x7F && *p > 0x1F) {
-        AppendEscapedCharForHTML(*p, result);
-      } else {
-        result->push_back('.');
-      }
-    }
-
-    result->push_back('\n');
-
-    buf += row_max;
-    buf_len -= row_max;
-  }
-}
-
 std::string FormatEntryInfo(disk_cache::Entry* entry,
                             const std::string& url_prefix) {
   std::string key = entry->GetKey();
@@ -111,6 +74,45 @@
   return GetInfoHTML(std::string(), context, url_prefix, out, callback);
 }
 
+// static
+void ViewCacheHelper::HexDump(const char *buf, size_t buf_len,
+                              std::string* result) {
+  const size_t kMaxRows = 16;
+  int offset = 0;
+
+  const unsigned char *p;
+  while (buf_len) {
+    base::StringAppendF(result, "%08x:  ", offset);
+    offset += kMaxRows;
+
+    p = (const unsigned char *) buf;
+
+    size_t i;
+    size_t row_max = std::min(kMaxRows, buf_len);
+
+    // print hex codes:
+    for (i = 0; i < row_max; ++i)
+      base::StringAppendF(result, "%02x  ", *p++);
+    for (i = row_max; i < kMaxRows; ++i)
+      result->append("    ");
+
+    // print ASCII glyphs if possible:
+    p = (const unsigned char *) buf;
+    for (i = 0; i < row_max; ++i, ++p) {
+      if (*p < 0x7F && *p > 0x1F) {
+        AppendEscapedCharForHTML(*p, result);
+      } else {
+        result->push_back('.');
+      }
+    }
+
+    result->push_back('\n');
+
+    buf += row_max;
+    buf_len -= row_max;
+  }
+}
+
 //-----------------------------------------------------------------------------
 
 int ViewCacheHelper::GetInfoHTML(const std::string& key,