about://appcache-internals enhancements

Enhancements to the about://appcache-internals pages.
* added a new page to list the entries in a cache
* added a new page to show an entry's headers and data

BUG=none
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92263

[michaeln, 2011-07-08 21:56:23]

ptal

[rvargas (doing something else), 2011-07-11 22:34:07]

LGTM

http://codereview.chromium.org/7326023/diff/30/net/url_request/view_cache_hel...
File net/url_request/view_cache_helper.h (right):

http://codereview.chromium.org/7326023/diff/30/net/url_request/view_cache_hel...
net/url_request/view_cache_helper.h:49: // The results are appended 'result' and
can be used in HTML pages provided
nit: s/'result'/to |result|

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/appcache_host.cc
File webkit/appcache/appcache_host.cc (right):

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/appcache_host....
webkit/appcache/appcache_host.cc:281: std::vector<AppCacheResourceInfo>*
resource_infos) {
nit: use AppCacheResourceInfoVector here?

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
File webkit/appcache/view_appcache_internals_job.cc (right):

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.cc:174: str.append("Fallback. ");
Is it intentional that this one ends with a period?. Is it a good idea to have
commas without knowing if there will be another item on the string?

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.cc:391: net::URLRequest* request,
AppCacheService* service,
nit: put the arguments on the previous line.

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.cc:427: net::URLRequest* request,
AppCacheService* service,
ditto

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.cc:463: virtual void
OnGroupLoaded(AppCacheGroup* group, const GURL& manifest_url) {
nit: Add OVERRIDE

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.cc:490: net::URLRequest* request,
AppCacheService* service,
ditto

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.cc:576: }  // anon namespace
s/anon namespace/namespace

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
File webkit/appcache/view_appcache_internals_job.h (right):

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.h:19: class
ViewAppCacheInternalsJobFactory {
I'm wondering if we should rename this file to xx_factory.h

[michaeln, 2011-07-12 23:35:26]

http://codereview.chromium.org/7326023/diff/30/net/url_request/view_cache_hel...
File net/url_request/view_cache_helper.h (right):

http://codereview.chromium.org/7326023/diff/30/net/url_request/view_cache_hel...
net/url_request/view_cache_helper.h:49: // The results are appended 'result' and
can be used in HTML pages provided
On 2011/07/11 22:34:07, rvargas wrote:
> nit: s/'result'/to |result|

Done.

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/appcache_host.cc
File webkit/appcache/appcache_host.cc (right):

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/appcache_host....
webkit/appcache/appcache_host.cc:281: std::vector<AppCacheResourceInfo>*
resource_infos) {
On 2011/07/11 22:34:07, rvargas wrote:
> nit: use AppCacheResourceInfoVector here?

Done.

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
File webkit/appcache/view_appcache_internals_job.cc (right):

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.cc:174: str.append("Fallback. ");
On 2011/07/11 22:34:07, rvargas wrote:
> Is it intentional that this one ends with a period?. Is it a good idea to have
> commas without knowing if there will be another item on the string?

Done, changed to a comma like the others. The URL is always the next item in the
resulting output.

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.cc:463: virtual void
OnGroupLoaded(AppCacheGroup* group, const GURL& manifest_url) {
On 2011/07/11 22:34:07, rvargas wrote:
> nit: Add OVERRIDE

Done.

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.cc:576: }  // anon namespace
On 2011/07/11 22:34:07, rvargas wrote:
> s/anon namespace/namespace

Done.

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
File webkit/appcache/view_appcache_internals_job.h (right):

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.h:19: class
ViewAppCacheInternalsJobFactory {
On 2011/07/11 22:34:07, rvargas wrote:
> I'm wondering if we should rename this file to xx_factory.h

AppCacheInternalsJobFactory.h maybe?

[rvargas (doing something else), 2011-07-13 02:07:14]

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
File webkit/appcache/view_appcache_internals_job.h (right):

http://codereview.chromium.org/7326023/diff/30/webkit/appcache/view_appcache_...
webkit/appcache/view_appcache_internals_job.h:19: class
ViewAppCacheInternalsJobFactory {
On 2011/07/12 23:35:26, michaeln wrote:
> On 2011/07/11 22:34:07, rvargas wrote:
> > I'm wondering if we should rename this file to xx_factory.h
> 
> AppCacheInternalsJobFactory.h maybe?

yeah, that also works...