AsyncOpenFileOnFileThread: Properly release file handle at the browser side.

AsyncOpenFileOnFileThread: Properly release file handle at the browser side.

BUG=79824
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91801

[yzshen1, 2011-07-07 22:17:01]

Hi, Antoine.

Would you please review it? Thanks!

[piman, 2011-07-07 22:22:30]

LGTM

[commit-bot: I haz the power, 2011-07-08 01:37:17]

Presubmit check for 7326007-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/renderer_host/render_message_filter.cc

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[yzshen1, 2011-07-08 01:43:58]

Hi, Brett.

I need an LGTM from an owner. Would you please take a look at it?
Thanks!

[brettw, 2011-07-08 01:55:25]

LGTM

http://codereview.chromium.org/7326007/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_message_filter.cc (right):

http://codereview.chromium.org/7326007/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_message_filter.cc:855:
IPC::GetFileHandleForProcess(file, peer_handle(), true):
Need an extra space before the :

[yzshen, 2011-07-08 02:08:29]

Thanks! :)

On Thu, Jul 7, 2011 at 6:55 PM, <brettw@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.**org/7326007/diff/1/content/**
>
browser/renderer_host/render_**message_filter.cc<http://codereview.chromium.org/7326007/diff/1/content/browser/renderer_host/render_message_filter.cc>
> File content/browser/renderer_host/**render_message_filter.cc (right):
>
> http://codereview.chromium.**org/7326007/diff/1/content/**
>
browser/renderer_host/render_**message_filter.cc#newcode855<http://codereview.chromium.org/7326007/diff/1/content/browser/renderer_host/render_message_filter.cc#newcode855>
> content/browser/renderer_host/**render_message_filter.cc:855:
>
> IPC::GetFileHandleForProcess(**file, peer_handle(), true):
> Need an extra space before the :
>
>
>
http://codereview.chromium.**org/7326007/<http://codereview.chromium.org/7326...
>



-- 
Best regards,
Yuzhu Shen.

[commit-bot: I haz the power, 2011-07-08 03:09:33]

Change committed as 91801