Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Issue 7326002: Fix the Extensions.Permissions_InstallCancel histogram. (Closed)

Created:
9 years, 5 months ago by jstritar%chromium.org
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews
Visibility:
Public.

Description

Fix the Extensions.Permissions_InstallCancel histograms. This makes sure we record the Permissions_Install* histograms for web store installs and cancelations. It also creates a few new histograms, starting with Permissions_WebStoreInstall, that are specific to the web store. BUG=87468 TEST=about:histograms/Extensions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/browser/extensions/extension_webstore_private_api.cc View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jstritar
9 years, 5 months ago (2011-07-07 19:30:38 UTC) #1
asargent_no_longer_on_chrome
LGTM
9 years, 5 months ago (2011-07-07 21:00:46 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 21:18:05 UTC) #3
Presubmit check for 7326002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
jstritar%chromium.org@gtempaccount.com is not in AUTHORS file. If you are a new
contributor, please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Powered by Google App Engine
This is Rietveld 408576698